database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-28 05:21:27 +03:00
Code

Improve defaults shown in postgresql.conf.sample and pg_settings

Browse Source 
Previously, these showed unlikely default values.  The new default value
128MB (since PG 10) is not always accurate since initdb tries several
increasing values, but it likely to be accurate.

Reported-by: Zhangjie <zhangjie2@fujitsu.com>

Discussion: https://postgr.es/m/TYWPR01MB7678772FD8640C404F1DC882F9079@TYWPR01MB7678.jpnprd01.prod.outlook.com

Author: Zhangjie

Backpatch-through: master
This commit is contained in:
Bruce Momjian 2021-08-23 12:33:38 -04:00
parent a3fcbcda75
commit f7bda63a48
3 changed files with 3 additions and 3 deletions
src
backend/utils/misc
guc.cpostgresql.conf.sample
bin/initdb
initdb.c

2
src/backend/utils/misc/guc.c

@ -2333,7 +2333,7 @@ static struct config_int ConfigureNamesInt[] =
GUC_UNIT_BLOCKS GUC_UNIT_BLOCKS
}, },
&NBuffers, &NBuffers,
1024, 16, INT_MAX / 2, 16384, 16, INT_MAX / 2,
NULL, NULL, NULL NULL, NULL, NULL
}, },

2
src/backend/utils/misc/postgresql.conf.sample

@ -124,7 +124,7 @@
# - Memory - # - Memory -
#shared_buffers = 32MB # min 128kB #shared_buffers = 128MB # min 128kB
# (change requires restart) # (change requires restart)
#huge_pages = try # on, off, or try #huge_pages = try # on, off, or try
# (change requires restart) # (change requires restart)

2
src/bin/initdb/initdb.c

@ -1071,7 +1071,7 @@ setup_config(void)
else else
snprintf(repltok, sizeof(repltok), "shared_buffers = %dkB", snprintf(repltok, sizeof(repltok), "shared_buffers = %dkB",
n_buffers * (BLCKSZ / 1024)); n_buffers * (BLCKSZ / 1024));
conflines = replace_token(conflines, "#shared_buffers = 32MB", repltok); conflines = replace_token(conflines, "#shared_buffers = 128MB", repltok);
#ifdef HAVE_UNIX_SOCKETS #ifdef HAVE_UNIX_SOCKETS
snprintf(repltok, sizeof(repltok), "#unix_socket_directories = '%s'", snprintf(repltok, sizeof(repltok), "#unix_socket_directories = '%s'",