database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-11 10:01:57 +03:00
Code Activity

Handle OID column inheritance correctly in ALTER TABLE ... INHERIT.

Browse Source 
Inheritance operations must treat the OID column, if any, much like
regular user columns.  But MergeAttributesIntoExisting() neglected to
do that, leading to weird results after a table with OIDs is associated
to a parent with OIDs via ALTER TABLE ... INHERIT.

Report and patch by Amit Langote, reviewed by Ashutosh Bapat, some
adjustments by me.  It's been broken all along, so back-patch to
all supported branches.

Discussion: https://postgr.es/m/cb13cfe7-a48c-5720-c383-bb843ab28298@lab.ntt.co.jp
This commit is contained in:
Tom Lane
2017-01-04 18:00:11 -05:00
parent 6e5de703b6
commit f64554b99a
3 changed files with 108 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/backend/commands/tablecmds.c
View File

@ -10329,6 +10329,39 @@ MergeAttributesIntoExisting(Relation child_rel, Relation parent_rel)
}
}
/*
* If the parent has an OID column, so must the child, and we'd better
* update the child's attinhcount and attislocal the same as for normal
* columns. We needn't check data type or not-nullness though.
*/
if (tupleDesc->tdhasoid)
{
/*
* Here we match by column number not name; the match *must* be the
* system column, not some random column named "oid".
*/
tuple = SearchSysCacheCopy2(ATTNUM,
ObjectIdGetDatum(RelationGetRelid(child_rel)),
Int16GetDatum(ObjectIdAttributeNumber));
if (HeapTupleIsValid(tuple))
{
Form_pg_attribute childatt = (Form_pg_attribute) GETSTRUCT(tuple);
/* See comments above; these changes should be the same */
childatt->attinhcount++;
simple_heap_update(attrrel, &tuple->t_self, tuple);
CatalogUpdateIndexes(attrrel, tuple);
heap_freetuple(tuple);
}
else
{
ereport(ERROR,
(errcode(ERRCODE_DATATYPE_MISMATCH),
errmsg("child table is missing column \"%s\"",
"oid")));
}
}
heap_close(attrrel, RowExclusiveLock);
}