diff --git a/src/bin/pg4_dump/common.c b/src/bin/pg4_dump/common.c index da66dc69291..0bf6cca533f 100644 --- a/src/bin/pg4_dump/common.c +++ b/src/bin/pg4_dump/common.c @@ -43,23 +43,6 @@ check_conn_and_db() } -/* dupstr : copies a string, while allocating space for it. - the CALLER is responsible for freeing the space - returns NULL if the argument is NULL*/ -char* -dupstr(char *s) -{ - char* result; - - if (s == NULL) - return NULL; - - result = (char*)malloc(strlen(s)+1); - strcpy(result, s); - return result; -} - - /* * findTypeByOid * given an oid of a type, return its typename @@ -173,7 +156,7 @@ parseArgTypes(char **argtypes, char* str) while ( (s = *str) != '\0') { if (s == ' ') { temp[j] = '\0'; - argtypes[argNum] = dupstr(temp); + argtypes[argNum] = strdup(temp); argNum++; j = 0; } else { @@ -184,7 +167,7 @@ parseArgTypes(char **argtypes, char* str) } if (j != 0) { temp[j] = '\0'; - argtypes[argNum] = dupstr(temp); + argtypes[argNum] = strdup(temp); } } diff --git a/src/bin/pg4_dump/pg4_dump.c b/src/bin/pg4_dump/pg4_dump.c index a7f54004dc1..9944ca1190e 100644 --- a/src/bin/pg4_dump/pg4_dump.c +++ b/src/bin/pg4_dump/pg4_dump.c @@ -289,19 +289,19 @@ getTypes(int *numTypes) i_typbyval = PQfnumberGroup(pbuf,0,"typbyval"); for (i=0;i #include +#include #include /* for MAXHOSTNAMELEN on most */ #ifdef PORTNAME_sparc_solaris #include /* for MAXHOSTNAMELEN on some */ @@ -31,22 +32,6 @@ #include "pg_dump.h" -/* dupstr : copies a string, while allocating space for it. - the CALLER is responsible for freeing the space - returns NULL if the argument is NULL*/ -char* -dupstr(char *s) -{ - char* result; - - if (s == NULL) - return NULL; - - result = (char*)malloc(strlen(s)+1); - strcpy(result, s); - return result; -} - /* * findTypeByOid * given an oid of a type, return its typename @@ -160,7 +145,7 @@ parseArgTypes(char **argtypes, char* str) while ( (s = *str) != '\0') { if (s == ' ') { temp[j] = '\0'; - argtypes[argNum] = dupstr(temp); + argtypes[argNum] = strdup(temp); argNum++; j = 0; } else { @@ -171,7 +156,7 @@ parseArgTypes(char **argtypes, char* str) } if (j != 0) { temp[j] = '\0'; - argtypes[argNum] = dupstr(temp); + argtypes[argNum] = strdup(temp); } } diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index c6fd237012c..bd02d0c1d30 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -20,7 +20,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.7 1996/08/24 20:49:22 scrappy Exp $ + * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.8 1996/09/16 06:05:54 scrappy Exp $ * * Modifications - 6/10/96 - dave@bensoft.com - version 1.13.dhb * @@ -305,19 +305,19 @@ getTypes(int *numTypes) i_typbyval = PQfnumber(res,"typbyval"); for (i=0;i 0) tblinfo[i].attlen[j] = tblinfo[i].attlen[j] - 4; @@ -883,12 +883,12 @@ getIndices(int *numIndices) i_indclassname = PQfnumber(res,"indclassname"); for (i=0;iopt.caption=NULL; else - if (!(settings->opt.caption=dupstr(optarg))) + if (!(settings->opt.caption=strdup(optarg))) { perror("malloc"); exit(1); @@ -787,7 +787,7 @@ HandleSlashCmds(PsqlSettings *settings, fs=optarg; if (settings->opt.fieldSep); free(settings->opt.fieldSep); - if (!(settings->opt.fieldSep=dupstr(fs))) + if (!(settings->opt.fieldSep=strdup(fs))) { perror("malloc"); exit(1); @@ -903,13 +903,13 @@ HandleSlashCmds(PsqlSettings *settings, settings->opt.html3 = settings->opt.expanded = 0; settings->opt.align = settings->opt.header = 1; free(settings->opt.fieldSep); - settings->opt.fieldSep=dupstr("|"); + settings->opt.fieldSep=strdup("|"); if (!settings->quiet) fprintf(stderr, "field separater changed to '%s'\n", settings->opt.fieldSep); } else { free(settings->opt.fieldSep); - settings->opt.fieldSep=dupstr(DEFAULT_FIELD_SEP); + settings->opt.fieldSep=strdup(DEFAULT_FIELD_SEP); if (!settings->quiet) fprintf(stderr, "field separater changed to '%s'\n", settings->opt.fieldSep); } @@ -923,7 +923,7 @@ HandleSlashCmds(PsqlSettings *settings, if (!optarg) settings->opt.tableOpt=NULL; else - if (!(settings->opt.tableOpt=dupstr(optarg))) + if (!(settings->opt.tableOpt=strdup(optarg))) { perror("malloc"); exit(1); @@ -1144,7 +1144,7 @@ main(int argc, char **argv) settings.opt.align = 1; settings.opt.header = 1; settings.queryFout = stdout; - settings.opt.fieldSep=dupstr(DEFAULT_FIELD_SEP); + settings.opt.fieldSep=strdup(DEFAULT_FIELD_SEP); settings.opt.pager = 1; if (!isatty(0) || !isatty(1)) settings.quiet = settings.notty = 1; diff --git a/src/bin/psql/stringutils.c b/src/bin/psql/stringutils.c index daeb120ef9a..42902e64384 100644 --- a/src/bin/psql/stringutils.c +++ b/src/bin/psql/stringutils.c @@ -7,7 +7,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/bin/psql/stringutils.c,v 1.3 1996/08/06 20:23:14 julian Exp $ + * $Header: /cvsroot/pgsql/src/bin/psql/stringutils.c,v 1.4 1996/09/16 06:06:17 scrappy Exp $ * *------------------------------------------------------------------------- */ @@ -57,22 +57,6 @@ char *doubleTrim(char *s) return s; } -/* dupstr : copies a string, while allocating space for it. - the CALLER is responsible for freeing the space - returns NULL if the argument is NULL */ -char *dupstr(char *s) -{ - char *result; - - if (s == NULL) - return NULL; - - result = (char*)malloc(strlen(s)+1); - strcpy(result, s); - return result; -} - - #ifdef STRINGUTILS_TEST void testStringUtils() { @@ -87,13 +71,13 @@ void testStringUtils() while (tests[i]!=NULL_STR) { char *t; - t = dupstr(tests[i]); + t = strdup(tests[i]); printf("leftTrim(%s) = ",t); printf("%sEND\n", leftTrim(t)); - t = dupstr(tests[i]); + t = strdup(tests[i]); printf("rightTrim(%s) = ",t); printf("%sEND\n", rightTrim(t)); - t = dupstr(tests[i]); + t = strdup(tests[i]); printf("doubleTrim(%s) = ",t); printf("%sEND\n", doubleTrim(t)); i++;