database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-22 14:32:25 +03:00
Code Activity

Re-order pg_attribute columns to eliminate some padding space.

Browse Source 
Now that attcompression is just a char, there's a lot of wasted
padding space after it.  Move it into the group of char-wide
columns to save a net of 4 bytes per pg_attribute entry.  While
we're at it, swap the order of attstorage and attalign to make for
a more logical grouping of these columns.

Also re-order actions in related code to match the new field ordering.

This patch also fixes one outright bug: equalTupleDescs() failed to
compare attcompression.  That could, for example, cause relcache
reload to fail to adopt a new value following a change.

Michael Paquier and Tom Lane, per a gripe from Andres Freund.

Discussion: https://postgr.es/m/20210517204803.iyk5wwvwgtjcmc5w@alap3.anarazel.de
This commit is contained in:
Tom Lane
2021-05-23 12:12:09 -04:00
parent bc2a389efb
commit f5024d8d7b
11 changed files with 80 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/access/spgist_private.h
View File

@@ -137,8 +137,8 @@ typedef struct SpGistTypeDesc
Oid type;
int16 attlen;
bool attbyval;
char attstorage;
char attalign;
char attstorage;
} SpGistTypeDesc;
typedef struct SpGistState