database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Fix bogus use of "long" in AllocSetCheck()

Browse Source 
Because long is 32-bit on 64-bit Windows, it isn't a good datatype to
store the difference between 2 pointers.  The under-sized type could
overflow and lead to scary warnings in MEMORY_CONTEXT_CHECKING builds,
such as:

WARNING:  problem in alloc set ExecutorState: bad single-chunk %p in block %p

However, the problem lies only in the code running the check, not from
an actual memory accounting bug.

Fix by using "Size" instead of "long".  This means using an unsigned
type rather than the previous signed type.  If the block's freeptr was
corrupted, we'd still catch that if the unsigned type wrapped.  Unsigned
allows us to avoid further needless complexities around comparing signed
and unsigned types.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Backpatch-through: 13
Discussion: https://postgr.es/m/CAApHDvo-RmiT4s33J=aC9C_-wPZjOXQ232V-EZFgKftSsNRi4w@mail.gmail.com
This commit is contained in:
David Rowley
2025-10-30 14:50:26 +13:00
parent 2992b9a07e
commit f3420e006e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/mmgr/aset.c
View File

@@ -1431,9 +1431,9 @@ AllocSetCheck(MemoryContext context)
prevblock = block, block = block->next) prevblock = block, block = block->next)
{ {
char *bpoz = ((char *) block) + ALLOC_BLOCKHDRSZ; char *bpoz = ((char *) block) + ALLOC_BLOCKHDRSZ;
long blk_used = block->freeptr - bpoz; Size blk_used = block->freeptr - bpoz;
long blk_data = 0; Size blk_data = 0;
long nchunks = 0; Size nchunks = 0;
if (set->keeper == block) if (set->keeper == block)
total_allocated += block->endptr - ((char *) set); total_allocated += block->endptr - ((char *) set);