database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-24 14:22:24 +03:00
Code Activity

Remove unnecessary PQconsumeInput call from PQputCopyData; it's redundant

Browse Source 
because pqSendSome will absorb input data anytime it'd be forced to block.
Avoiding a kernel call per PQputCopyData call helps COPY speed materially.

Alon Goldshuv
This commit is contained in:
Tom Lane
2006-01-25 20:44:49 +00:00
parent b34608fbdd
commit f31a58481c
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/interfaces/libpq/fe-exec.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/interfaces/libpq/fe-exec.c,v 1.176.2.1 2005/11/22 18:23:29 momjian Exp $ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-exec.c,v 1.176.2.2 2006/01/25 20:44:49 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -1476,13 +1476,13 @@ PQputCopyData(PGconn *conn, const char *buffer, int nbytes)
} }
/* /*
* Check for NOTICE messages coming back from the server. Since the * Process any NOTICE or NOTIFY messages that might be pending in the
* server might generate multiple notices during the COPY, we have to * input buffer. Since the server might generate many notices during
* consume those in a reasonably prompt fashion to prevent the comm * the COPY, we want to clean those out reasonably promptly to prevent
* buffers from filling up and possibly blocking the server. * indefinite expansion of the input buffer. (Note: the actual read
* of input data into the input buffer happens down inside pqSendSome,
* but it's not authorized to get rid of the data again.)
*/ */
if (!PQconsumeInput(conn))
return -1; /* I/O failure */
parseInput(conn); parseInput(conn);
if (nbytes > 0) if (nbytes > 0)