database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-18 04:29:09 +03:00
Code Activity

Fix use-after-free issue in slot synchronization.

Browse Source 
Author: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 18, where it was introduced
Discussion: https://postgr.es/m/CANhcyEXMrcEdzj-RNGJam0nJHM4y+ttdWsgUCFmXciM7BNKc7A@mail.gmail.com
This commit is contained in:
Amit Kapila
2025-09-03 06:31:05 +00:00
parent db9405493b
commit f2dbc83501
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/replication/logical/slotsync.c
View File

@@ -1476,7 +1476,6 @@ ReplSlotSyncWorkerMain(const void *startup_data, size_t startup_data_len)
*/ */
wrconn = walrcv_connect(PrimaryConnInfo, false, false, false, wrconn = walrcv_connect(PrimaryConnInfo, false, false, false,
app_name.data, &err); app_name.data, &err);
pfree(app_name.data);
if (!wrconn) if (!wrconn)
ereport(ERROR, ereport(ERROR,
@@ -1484,6 +1483,8 @@ ReplSlotSyncWorkerMain(const void *startup_data, size_t startup_data_len)
errmsg("synchronization worker \"%s\" could not connect to the primary server: %s", errmsg("synchronization worker \"%s\" could not connect to the primary server: %s",
app_name.data, err)); app_name.data, err));
pfree(app_name.data);
/* /*
* Register the disconnection callback. * Register the disconnection callback.
* *

3
src/backend/replication/slotfuncs.c
View File

@@ -921,7 +921,6 @@ pg_sync_replication_slots(PG_FUNCTION_ARGS)
/* Connect to the primary server. */ /* Connect to the primary server. */
wrconn = walrcv_connect(PrimaryConnInfo, false, false, false, wrconn = walrcv_connect(PrimaryConnInfo, false, false, false,
app_name.data, &err); app_name.data, &err);
pfree(app_name.data);
if (!wrconn) if (!wrconn)
ereport(ERROR, ereport(ERROR,
@@ -929,6 +928,8 @@ pg_sync_replication_slots(PG_FUNCTION_ARGS)
errmsg("synchronization worker \"%s\" could not connect to the primary server: %s", errmsg("synchronization worker \"%s\" could not connect to the primary server: %s",
app_name.data, err)); app_name.data, err));
pfree(app_name.data);
SyncReplicationSlots(wrconn); SyncReplicationSlots(wrconn);
walrcv_disconnect(wrconn); walrcv_disconnect(wrconn);