database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-05 07:21:24 +03:00
Code Activity

Code review for logical decoding patch.

Browse Source 
Post-commit review identified a number of places where addition was
used instead of multiplication or memory wasn't zeroed where it should
have been.  This commit also fixes one case where a structure member
was mis-initialized, and moves another memory allocation closer to
the place where the allocated storage is used for clarity.

Andres Freund
This commit is contained in:
Robert Haas
2014-05-09 10:44:04 -04:00
parent b2dada8f5f
commit f1d8dd3647
2 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/replication/logical/reorderbuffer.c
View File

@ -2064,15 +2064,15 @@ ReorderBufferSerializeChange(ReorderBuffer *rb, ReorderBufferTXN *txn,
if (snap->xcnt) if (snap->xcnt)
{ {
memcpy(data, snap->xip, memcpy(data, snap->xip,
sizeof(TransactionId) + snap->xcnt); sizeof(TransactionId) * snap->xcnt);
data += sizeof(TransactionId) + snap->xcnt; data += sizeof(TransactionId) * snap->xcnt;
} }
if (snap->subxcnt) if (snap->subxcnt)
{ {
memcpy(data, snap->subxip, memcpy(data, snap->subxip,
sizeof(TransactionId) + snap->subxcnt); sizeof(TransactionId) * snap->subxcnt);
data += sizeof(TransactionId) + snap->subxcnt; data += sizeof(TransactionId) * snap->subxcnt;
} }
break; break;
} }
@ -2168,15 +2168,12 @@ ReorderBufferRestoreChanges(ReorderBuffer *rb, ReorderBufferTXN *txn,
} }
ReorderBufferSerializeReserve(rb, sizeof(ReorderBufferDiskChange));
/* /*
* Read the statically sized part of a change which has information * Read the statically sized part of a change which has information
* about the total size. If we couldn't read a record, we're at the * about the total size. If we couldn't read a record, we're at the
* end of this file. * end of this file.
*/ */
ReorderBufferSerializeReserve(rb, sizeof(ReorderBufferDiskChange));
readBytes = read(*fd, rb->outbuf, sizeof(ReorderBufferDiskChange)); readBytes = read(*fd, rb->outbuf, sizeof(ReorderBufferDiskChange));
/* eof */ /* eof */

11
src/backend/replication/logical/snapbuild.c
View File

@ -307,8 +307,7 @@ AllocateSnapshotBuilder(ReorderBuffer *reorder,
builder->committed.xip = builder->committed.xip =
palloc0(builder->committed.xcnt_space * sizeof(TransactionId)); palloc0(builder->committed.xcnt_space * sizeof(TransactionId));
builder->committed.includes_all_transactions = true; builder->committed.includes_all_transactions = true;
builder->committed.xip =
palloc0(builder->committed.xcnt_space * sizeof(TransactionId));
builder->initial_xmin_horizon = xmin_horizon; builder->initial_xmin_horizon = xmin_horizon;
builder->transactions_after = start_lsn; builder->transactions_after = start_lsn;
@ -1691,7 +1690,7 @@ SnapBuildRestore(SnapBuild *builder, XLogRecPtr lsn)
/* restore running xacts information */ /* restore running xacts information */
sz = sizeof(TransactionId) * ondisk.builder.running.xcnt_space; sz = sizeof(TransactionId) * ondisk.builder.running.xcnt_space;
ondisk.builder.running.xip = MemoryContextAlloc(builder->context, sz); ondisk.builder.running.xip = MemoryContextAllocZero(builder->context, sz);
readBytes = read(fd, ondisk.builder.running.xip, sz); readBytes = read(fd, ondisk.builder.running.xip, sz);
if (readBytes != sz) if (readBytes != sz)
{ {
@ -1705,7 +1704,7 @@ SnapBuildRestore(SnapBuild *builder, XLogRecPtr lsn)
/* restore committed xacts information */ /* restore committed xacts information */
sz = sizeof(TransactionId) * ondisk.builder.committed.xcnt; sz = sizeof(TransactionId) * ondisk.builder.committed.xcnt;
ondisk.builder.committed.xip = MemoryContextAlloc(builder->context, sz); ondisk.builder.committed.xip = MemoryContextAllocZero(builder->context, sz);
readBytes = read(fd, ondisk.builder.committed.xip, sz); readBytes = read(fd, ondisk.builder.committed.xip, sz);
if (readBytes != sz) if (readBytes != sz)
{ {
@ -1763,10 +1762,10 @@ SnapBuildRestore(SnapBuild *builder, XLogRecPtr lsn)
} }
ondisk.builder.committed.xip = NULL; ondisk.builder.committed.xip = NULL;
builder->running.xcnt = ondisk.builder.committed.xcnt; builder->running.xcnt = ondisk.builder.running.xcnt;
if (builder->running.xip) if (builder->running.xip)
pfree(builder->running.xip); pfree(builder->running.xip);
builder->running.xcnt_space = ondisk.builder.committed.xcnt_space; builder->running.xcnt_space = ondisk.builder.running.xcnt_space;
builder->running.xip = ondisk.builder.running.xip; builder->running.xip = ondisk.builder.running.xip;
/* our snapshot is not interesting anymore, build a new one */ /* our snapshot is not interesting anymore, build a new one */