database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-09 22:41:56 +03:00
Code Activity

Initialize HASHCTL differently, to suppress Coverity warning

Browse Source 
Coverity complained that the hash_create() call might access
hash_table_ctl->hctl. That's a false alarm, hash_create() only
accesses that field when passed the HASH_SHARED_MEM flag. Try to
silence it by using a plain local variable instead of a const. That's
how the HASHCTL is initialized in all the other hash_create() calls.
This commit is contained in:
Heikki Linnakangas
2024-08-11 20:21:16 +03:00
parent b2be5cb2ab
commit f011e82c2c
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/access/transam/xlogprefetcher.c
View File

@ -362,17 +362,15 @@ XLogPrefetcher *
XLogPrefetcherAllocate(XLogReaderState *reader) XLogPrefetcherAllocate(XLogReaderState *reader)
{ {
XLogPrefetcher *prefetcher; XLogPrefetcher *prefetcher;
const HASHCTL hash_table_ctl = { HASHCTL ctl;
.keysize = sizeof(RelFileLocator),
.entrysize = sizeof(XLogPrefetcherFilter)
};
prefetcher = palloc0(sizeof(XLogPrefetcher)); prefetcher = palloc0(sizeof(XLogPrefetcher));
prefetcher->reader = reader; prefetcher->reader = reader;
ctl.keysize = sizeof(RelFileLocator);
ctl.entrysize = sizeof(XLogPrefetcherFilter);
prefetcher->filter_table = hash_create("XLogPrefetcherFilterTable", 1024, prefetcher->filter_table = hash_create("XLogPrefetcherFilterTable", 1024,
&hash_table_ctl, &ctl, HASH_ELEM | HASH_BLOBS);
HASH_ELEM | HASH_BLOBS);
dlist_init(&prefetcher->filter_queue); dlist_init(&prefetcher->filter_queue);
SharedStats->wal_distance = 0; SharedStats->wal_distance = 0;