database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-20 15:22:23 +03:00
Code Activity

pg_upgrade: Upgrade an Assert to a real 'if' test

Browse Source 
It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql
This commit is contained in:
Alvaro Herrera
2022-03-23 19:23:51 +01:00
parent 199cd7b59a
commit efe44fb2f6
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/pg_rewind/parsexlog.c
View File

@ -106,7 +106,11 @@ extractPageMap(const char *datadir, XLogRecPtr startpoint, int tliIndex,
* If 'endpoint' didn't point exactly at a record boundary, the caller * If 'endpoint' didn't point exactly at a record boundary, the caller
* messed up. * messed up.
*/ */
Assert(xlogreader->EndRecPtr == endpoint); if (xlogreader->EndRecPtr != endpoint)
pg_fatal("end pointer %X/%X is not a valid end point; expected %X/%X",
(uint32) (endpoint >> 32), (uint32) (endpoint),
(uint32) (xlogreader->EndRecPtr >> 32), (uint32)
(xlogreader->EndRecPtr));
XLogReaderFree(xlogreader); XLogReaderFree(xlogreader);
if (xlogreadfd != -1) if (xlogreadfd != -1)