database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Print WAL position correctly in pg_rewind error message.

Browse Source 
This has been wrong ever since pg_rewind was added. The if-branch just
above this, where we print the same error with an extra message supplied
by XLogReadRecord() got this right, but the variable name was wrong in the
else-branch. As a consequence, the error printed the WAL position as
0/0 if there was an error reading a WAL file.

Backpatch to 9.5, where pg_rewind was added.
This commit is contained in:
Heikki Linnakangas
2019-07-30 21:14:14 +03:00
parent d452d0cf6f
commit ee3f036861
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/bin/pg_rewind/parsexlog.c
View File

@@ -89,8 +89,7 @@ extractPageMap(const char *datadir, XLogRecPtr startpoint, TimeLineID tli,
errormsg); errormsg);
else else
pg_fatal("could not read WAL record at %X/%X\n", pg_fatal("could not read WAL record at %X/%X\n",
(uint32) (startpoint >> 32), (uint32) (errptr >> 32), (uint32) (errptr));
(uint32) (startpoint));
} }
extractPageInfo(xlogreader); extractPageInfo(xlogreader);