database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-21 10:42:50 +03:00
Code Activity

jit: Do not try to shut down LLVM state in case of LLVM triggered errors.

Browse Source 
If an allocation failed within LLVM it is not safe to call back into LLVM as
LLVM is not generally safe against exceptions / stack-unwinding. Thus errors
while in LLVM code are promoted to FATAL. However llvm_shutdown() did call
back into LLVM even in such cases, while llvm_release_context() was careful
not to do so.

We cannot generally skip shutting down LLVM, as that can break profiling. But
it's OK to do so if there was an error from within LLVM.

Reported-By: Jelte Fennema <Jelte.Fennema@microsoft.com>
Author: Andres Freund <andres@anarazel.de>
Author: Justin Pryzby <pryzby@telsasoft.com>
Discussion: https://postgr.es/m/AM5PR83MB0178C52CCA0A8DEA0207DC14F7FF9@AM5PR83MB0178.EURPRD83.prod.outlook.com
Backpatch: 11-, where jit was introduced
This commit is contained in:
Andres Freund
2021-09-13 18:07:19 -07:00
parent 026ed8efd6
commit edb4d95ddf
3 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/jit/llvm/llvmjit_error.cpp
View File

@@ -83,6 +83,16 @@ llvm_leave_fatal_on_oom(void)
}
}
/*
* Are we currently in an fatal-on-oom section? Useful to skip cleanup in case
* of errors.
*/
bool
llvm_in_fatal_on_oom(void)
{
return fatal_new_handler_depth > 0;
}
/*
* Reset fatal error handling. This should only be called in error recovery
* loops like PostgresMain()'s.