database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-27 22:56:53 +03:00
Code

Fix waits of REINDEX CONCURRENTLY for indexes with predicates or expressions

Browse Source 
As introduced by f9900df5f94, a REINDEX CONCURRENTLY job done for an
index with predicates or expressions would set PROC_IN_SAFE_IC in its
MyProc->statusFlags, causing it to be ignored by other concurrent
operations.

Such concurrent index rebuilds should never be ignored, as a predicate
or an expression could call a user-defined function that accesses a
different table than the table where the index is rebuilt.

A test that uses injection points is added, backpatched down to 17.
Michail has proposed a different test, but I have added something
simpler with more coverage.

Oversight in f9900df5f949.

Author: Michail Nikolaev
Discussion: https://postgr.es/m/CANtu0oj9A3kZVduFTG0vrmGnKB+DCHgEpzOp0qAyOgmks84j0w@mail.gmail.com
Backpatch-through: 14
This commit is contained in:
Michael Paquier 2024-09-09 13:50:02 +09:00
parent dd20f950d4
commit edb0f6e41b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/commands/indexcmds.c
View File

@ -3739,8 +3739,8 @@ ReindexRelationConcurrently(Oid relationOid, ReindexParams *params)
save_nestlevel = NewGUCNestLevel(); save_nestlevel = NewGUCNestLevel();
/* determine safety of this index for set_indexsafe_procflags */ /* determine safety of this index for set_indexsafe_procflags */
idx->safe = (indexRel->rd_indexprs == NIL && idx->safe = (RelationGetIndexExpressions(indexRel) == NIL &&
indexRel->rd_indpred == NIL); RelationGetIndexPredicate(indexRel) == NIL);
idx->tableId = RelationGetRelid(heapRel); idx->tableId = RelationGetRelid(heapRel);
idx->amId = indexRel->rd_rel->relam; idx->amId = indexRel->rd_rel->relam;