database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-22 23:02:54 +03:00
Code

Remove unnecessary (char *) casts [xlog]

Browse Source 
Remove (char *) casts no longer needed after XLogRegisterData() and
XLogRegisterBufData() argument type change.

Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
This commit is contained in:
Peter Eisentraut 2025-02-11 22:03:29 +01:00
parent cdaeff9b39
commit ed5e5f0710
39 changed files with 232 additions and 232 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pg_visibility/pg_visibility.c
View File

@ -424,7 +424,7 @@ pg_truncate_visibility_map(PG_FUNCTION_ARGS)
xlrec.flags = SMGR_TRUNCATE_VM; xlrec.flags = SMGR_TRUNCATE_VM;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
lsn = XLogInsert(RM_SMGR_ID, lsn = XLogInsert(RM_SMGR_ID,
XLOG_SMGR_TRUNCATE | XLR_SPECIAL_REL_UPDATE); XLOG_SMGR_TRUNCATE | XLR_SPECIAL_REL_UPDATE);

2
src/backend/access/brin/brin.c
View File

@ -1135,7 +1135,7 @@ brinbuild(Relation heap, Relation index, IndexInfo *indexInfo)
xlrec.pagesPerRange = BrinGetPagesPerRange(index); xlrec.pagesPerRange = BrinGetPagesPerRange(index);
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBrinCreateIdx); XLogRegisterData(&xlrec, SizeOfBrinCreateIdx);
XLogRegisterBuffer(0, meta, REGBUF_WILL_INIT | REGBUF_STANDARD); XLogRegisterBuffer(0, meta, REGBUF_WILL_INIT | REGBUF_STANDARD);
recptr = XLogInsert(RM_BRIN_ID, XLOG_BRIN_CREATE_INDEX); recptr = XLogInsert(RM_BRIN_ID, XLOG_BRIN_CREATE_INDEX);

12
src/backend/access/brin/brin_pageops.c
View File

@ -190,10 +190,10 @@ brin_doupdate(Relation idxrel, BlockNumber pagesPerRange,
xlrec.offnum = oldoff; xlrec.offnum = oldoff;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBrinSamepageUpdate); XLogRegisterData(&xlrec, SizeOfBrinSamepageUpdate);
XLogRegisterBuffer(0, oldbuf, REGBUF_STANDARD); XLogRegisterBuffer(0, oldbuf, REGBUF_STANDARD);
XLogRegisterBufData(0, (const char *) newtup, newsz); XLogRegisterBufData(0, newtup, newsz);
recptr = XLogInsert(RM_BRIN_ID, info); recptr = XLogInsert(RM_BRIN_ID, info);
@ -282,10 +282,10 @@ brin_doupdate(Relation idxrel, BlockNumber pagesPerRange,
XLogBeginInsert(); XLogBeginInsert();
/* new page */ /* new page */
XLogRegisterData((char *) &xlrec, SizeOfBrinUpdate); XLogRegisterData(&xlrec, SizeOfBrinUpdate);
XLogRegisterBuffer(0, newbuf, REGBUF_STANDARD | (extended ? REGBUF_WILL_INIT : 0)); XLogRegisterBuffer(0, newbuf, REGBUF_STANDARD | (extended ? REGBUF_WILL_INIT : 0));
XLogRegisterBufData(0, (const char *) newtup, newsz); XLogRegisterBufData(0, newtup, newsz);
/* revmap page */ /* revmap page */
XLogRegisterBuffer(1, revmapbuf, 0); XLogRegisterBuffer(1, revmapbuf, 0);
@ -435,10 +435,10 @@ brin_doinsert(Relation idxrel, BlockNumber pagesPerRange,
xlrec.offnum = off; xlrec.offnum = off;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBrinInsert); XLogRegisterData(&xlrec, SizeOfBrinInsert);
XLogRegisterBuffer(0, *buffer, REGBUF_STANDARD | (extended ? REGBUF_WILL_INIT : 0)); XLogRegisterBuffer(0, *buffer, REGBUF_STANDARD | (extended ? REGBUF_WILL_INIT : 0));
XLogRegisterBufData(0, (char *) tup, itemsz); XLogRegisterBufData(0, tup, itemsz);
XLogRegisterBuffer(1, revmapbuf, 0); XLogRegisterBuffer(1, revmapbuf, 0);

4
src/backend/access/brin/brin_revmap.c
View File

@ -416,7 +416,7 @@ brinRevmapDesummarizeRange(Relation idxrel, BlockNumber heapBlk)
xlrec.regOffset = regOffset; xlrec.regOffset = regOffset;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBrinDesummarize); XLogRegisterData(&xlrec, SizeOfBrinDesummarize);
XLogRegisterBuffer(0, revmapBuf, 0); XLogRegisterBuffer(0, revmapBuf, 0);
XLogRegisterBuffer(1, regBuf, REGBUF_STANDARD); XLogRegisterBuffer(1, regBuf, REGBUF_STANDARD);
recptr = XLogInsert(RM_BRIN_ID, XLOG_BRIN_DESUMMARIZE); recptr = XLogInsert(RM_BRIN_ID, XLOG_BRIN_DESUMMARIZE);
@ -627,7 +627,7 @@ revmap_physical_extend(BrinRevmap *revmap)
xlrec.targetBlk = mapBlk; xlrec.targetBlk = mapBlk;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBrinRevmapExtend); XLogRegisterData(&xlrec, SizeOfBrinRevmapExtend);
XLogRegisterBuffer(0, revmap->rm_metaBuf, REGBUF_STANDARD); XLogRegisterBuffer(0, revmap->rm_metaBuf, REGBUF_STANDARD);
XLogRegisterBuffer(1, buf, REGBUF_WILL_INIT); XLogRegisterBuffer(1, buf, REGBUF_WILL_INIT);

6
src/backend/access/gin/ginbtree.c
View File

@ -423,7 +423,7 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
xlrec.flags = xlflags; xlrec.flags = xlflags;
XLogRegisterData((char *) &xlrec, sizeof(ginxlogInsert)); XLogRegisterData(&xlrec, sizeof(ginxlogInsert));
/* /*
* Log information about child if this was an insertion of a * Log information about child if this was an insertion of a
@ -433,7 +433,7 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
{ {
BlockIdSet(&childblknos[0], BufferGetBlockNumber(childbuf)); BlockIdSet(&childblknos[0], BufferGetBlockNumber(childbuf));
BlockIdSet(&childblknos[1], GinPageGetOpaque(childpage)->rightlink); BlockIdSet(&childblknos[1], GinPageGetOpaque(childpage)->rightlink);
XLogRegisterData((char *) childblknos, XLogRegisterData(childblknos,
sizeof(BlockIdData) * 2); sizeof(BlockIdData) * 2);
} }
@ -617,7 +617,7 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
if (BufferIsValid(childbuf)) if (BufferIsValid(childbuf))
XLogRegisterBuffer(3, childbuf, REGBUF_STANDARD); XLogRegisterBuffer(3, childbuf, REGBUF_STANDARD);
XLogRegisterData((char *) &data, sizeof(ginxlogSplit)); XLogRegisterData(&data, sizeof(ginxlogSplit));
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_SPLIT); recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_SPLIT);

8
src/backend/access/gin/gindatapage.c
View File

@ -63,7 +63,7 @@ typedef struct
* If we need WAL data representing the reconstructed leaf page, it's * If we need WAL data representing the reconstructed leaf page, it's
* stored here by computeLeafRecompressWALData. * stored here by computeLeafRecompressWALData.
*/ */
char *walinfo; /* buffer start */ void *walinfo; /* buffer start */
int walinfolen; /* and length */ int walinfolen; /* and length */
} disassembledLeaf; } disassembledLeaf;
@ -1173,7 +1173,7 @@ dataExecPlaceToPageInternal(GinBtree btree, Buffer buf, GinBtreeStack *stack,
data.newitem = *pitem; data.newitem = *pitem;
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterBufData(0, (char *) &data, XLogRegisterBufData(0, &data,
sizeof(ginxlogInsertDataInternal)); sizeof(ginxlogInsertDataInternal));
} }
} }
@ -1844,9 +1844,9 @@ createPostingTree(Relation index, ItemPointerData *items, uint32 nitems,
data.size = rootsize; data.size = rootsize;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &data, sizeof(ginxlogCreatePostingTree)); XLogRegisterData(&data, sizeof(ginxlogCreatePostingTree));
XLogRegisterData((char *) GinDataLeafPageGetPostingList(page), XLogRegisterData(GinDataLeafPageGetPostingList(page),
rootsize); rootsize);
XLogRegisterBuffer(0, buffer, REGBUF_WILL_INIT); XLogRegisterBuffer(0, buffer, REGBUF_WILL_INIT);

4
src/backend/access/gin/ginentrypage.c
View File

@ -585,9 +585,9 @@ entryExecPlaceToPage(GinBtree btree, Buffer buf, GinBtreeStack *stack,
data.offset = off; data.offset = off;
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterBufData(0, (char *) &data, XLogRegisterBufData(0, &data,
offsetof(ginxlogInsertEntry, tuple)); offsetof(ginxlogInsertEntry, tuple));
XLogRegisterBufData(0, (char *) insertData->entry, XLogRegisterBufData(0, insertData->entry,
IndexTupleSize(insertData->entry)); IndexTupleSize(insertData->entry));
} }
} }

6
src/backend/access/gin/ginfast.c
View File

@ -122,7 +122,7 @@ writeListPage(Relation index, Buffer buffer,
data.ntuples = ntuples; data.ntuples = ntuples;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &data, sizeof(ginxlogInsertListPage)); XLogRegisterData(&data, sizeof(ginxlogInsertListPage));
XLogRegisterBuffer(0, buffer, REGBUF_WILL_INIT); XLogRegisterBuffer(0, buffer, REGBUF_WILL_INIT);
XLogRegisterBufData(0, workspace.data, size); XLogRegisterBufData(0, workspace.data, size);
@ -431,7 +431,7 @@ ginHeapTupleFastInsert(GinState *ginstate, GinTupleCollector *collector)
memcpy(&data.metadata, metadata, sizeof(GinMetaPageData)); memcpy(&data.metadata, metadata, sizeof(GinMetaPageData));
XLogRegisterBuffer(0, metabuffer, REGBUF_WILL_INIT | REGBUF_STANDARD); XLogRegisterBuffer(0, metabuffer, REGBUF_WILL_INIT | REGBUF_STANDARD);
XLogRegisterData((char *) &data, sizeof(ginxlogUpdateMeta)); XLogRegisterData(&data, sizeof(ginxlogUpdateMeta));
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_UPDATE_META_PAGE); recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_UPDATE_META_PAGE);
PageSetLSN(metapage, recptr); PageSetLSN(metapage, recptr);
@ -646,7 +646,7 @@ shiftList(Relation index, Buffer metabuffer, BlockNumber newHead,
memcpy(&data.metadata, metadata, sizeof(GinMetaPageData)); memcpy(&data.metadata, metadata, sizeof(GinMetaPageData));
XLogRegisterData((char *) &data, XLogRegisterData(&data,
sizeof(ginxlogDeleteListPages)); sizeof(ginxlogDeleteListPages));
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_DELETE_LISTPAGE); recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_DELETE_LISTPAGE);

2
src/backend/access/gin/ginutil.c
View File

@ -689,7 +689,7 @@ ginUpdateStats(Relation index, const GinStatsData *stats, bool is_build)
memcpy(&data.metadata, metadata, sizeof(GinMetaPageData)); memcpy(&data.metadata, metadata, sizeof(GinMetaPageData));
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &data, sizeof(ginxlogUpdateMeta)); XLogRegisterData(&data, sizeof(ginxlogUpdateMeta));
XLogRegisterBuffer(0, metabuffer, REGBUF_WILL_INIT | REGBUF_STANDARD); XLogRegisterBuffer(0, metabuffer, REGBUF_WILL_INIT | REGBUF_STANDARD);
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_UPDATE_META_PAGE); recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_UPDATE_META_PAGE);

2
src/backend/access/gin/ginvacuum.c
View File

@ -216,7 +216,7 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn
data.rightLink = GinPageGetOpaque(page)->rightlink; data.rightLink = GinPageGetOpaque(page)->rightlink;
data.deleteXid = GinPageGetDeleteXid(page); data.deleteXid = GinPageGetDeleteXid(page);
XLogRegisterData((char *) &data, sizeof(ginxlogDeletePage)); XLogRegisterData(&data, sizeof(ginxlogDeletePage));
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_DELETE_PAGE); recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_DELETE_PAGE);
PageSetLSN(page, recptr); PageSetLSN(page, recptr);

22
src/backend/access/gist/gistxlog.c
View File

@ -528,14 +528,14 @@ gistXLogSplit(bool page_is_leaf,
* of buffer or data registrations here, make sure you modify the * of buffer or data registrations here, make sure you modify the
* XLogEnsureRecordSpace() calls accordingly! * XLogEnsureRecordSpace() calls accordingly!
*/ */
XLogRegisterData((char *) &xlrec, sizeof(gistxlogPageSplit)); XLogRegisterData(&xlrec, sizeof(gistxlogPageSplit));
i = 1; i = 1;
for (ptr = dist; ptr; ptr = ptr->next) for (ptr = dist; ptr; ptr = ptr->next)
{ {
XLogRegisterBuffer(i, ptr->buffer, REGBUF_WILL_INIT); XLogRegisterBuffer(i, ptr->buffer, REGBUF_WILL_INIT);
XLogRegisterBufData(i, (char *) &(ptr->block.num), sizeof(int)); XLogRegisterBufData(i, &(ptr->block.num), sizeof(int));
XLogRegisterBufData(i, (char *) ptr->list, ptr->lenlist); XLogRegisterBufData(i, ptr->list, ptr->lenlist);
i++; i++;
} }
@ -559,7 +559,7 @@ gistXLogPageDelete(Buffer buffer, FullTransactionId xid,
xlrec.downlinkOffset = downlinkOffset; xlrec.downlinkOffset = downlinkOffset;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfGistxlogPageDelete); XLogRegisterData(&xlrec, SizeOfGistxlogPageDelete);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);
XLogRegisterBuffer(1, parentBuffer, REGBUF_STANDARD); XLogRegisterBuffer(1, parentBuffer, REGBUF_STANDARD);
@ -583,7 +583,7 @@ gistXLogAssignLSN(void)
*/ */
XLogBeginInsert(); XLogBeginInsert();
XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT); XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT);
XLogRegisterData((char *) &dummy, sizeof(dummy)); XLogRegisterData(&dummy, sizeof(dummy));
return XLogInsert(RM_GIST_ID, XLOG_GIST_ASSIGN_LSN); return XLogInsert(RM_GIST_ID, XLOG_GIST_ASSIGN_LSN);
} }
@ -609,7 +609,7 @@ gistXLogPageReuse(Relation rel, Relation heaprel,
xlrec_reuse.snapshotConflictHorizon = deleteXid; xlrec_reuse.snapshotConflictHorizon = deleteXid;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec_reuse, SizeOfGistxlogPageReuse); XLogRegisterData(&xlrec_reuse, SizeOfGistxlogPageReuse);
XLogInsert(RM_GIST_ID, XLOG_GIST_PAGE_REUSE); XLogInsert(RM_GIST_ID, XLOG_GIST_PAGE_REUSE);
} }
@ -639,14 +639,14 @@ gistXLogUpdate(Buffer buffer,
xlrec.ntoinsert = ituplen; xlrec.ntoinsert = ituplen;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(gistxlogPageUpdate)); XLogRegisterData(&xlrec, sizeof(gistxlogPageUpdate));
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);
XLogRegisterBufData(0, (char *) todelete, sizeof(OffsetNumber) * ntodelete); XLogRegisterBufData(0, todelete, sizeof(OffsetNumber) * ntodelete);
/* new tuples */ /* new tuples */
for (i = 0; i < ituplen; i++) for (i = 0; i < ituplen; i++)
XLogRegisterBufData(0, (char *) (itup[i]), IndexTupleSize(itup[i])); XLogRegisterBufData(0, itup[i], IndexTupleSize(itup[i]));
/* /*
* Include a full page image of the child buf. (only necessary if a * Include a full page image of the child buf. (only necessary if a
@ -678,14 +678,14 @@ gistXLogDelete(Buffer buffer, OffsetNumber *todelete, int ntodelete,
xlrec.ntodelete = ntodelete; xlrec.ntodelete = ntodelete;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfGistxlogDelete); XLogRegisterData(&xlrec, SizeOfGistxlogDelete);
/* /*
* We need the target-offsets array whether or not we store the whole * We need the target-offsets array whether or not we store the whole
* buffer, to allow us to find the snapshotConflictHorizon on a standby * buffer, to allow us to find the snapshotConflictHorizon on a standby
* server. * server.
*/ */
XLogRegisterData((char *) todelete, ntodelete * sizeof(OffsetNumber)); XLogRegisterData(todelete, ntodelete * sizeof(OffsetNumber));
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);

6
src/backend/access/hash/hash.c
View File

@ -616,7 +616,7 @@ loop_top:
xlrec.ntuples = metap->hashm_ntuples; xlrec.ntuples = metap->hashm_ntuples;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashUpdateMetaPage); XLogRegisterData(&xlrec, SizeOfHashUpdateMetaPage);
XLogRegisterBuffer(0, metabuf, REGBUF_STANDARD); XLogRegisterBuffer(0, metabuf, REGBUF_STANDARD);
@ -823,7 +823,7 @@ hashbucketcleanup(Relation rel, Bucket cur_bucket, Buffer bucket_buf,
xlrec.is_primary_bucket_page = (buf == bucket_buf); xlrec.is_primary_bucket_page = (buf == bucket_buf);
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashDelete); XLogRegisterData(&xlrec, SizeOfHashDelete);
/* /*
* bucket buffer was not changed, but still needs to be * bucket buffer was not changed, but still needs to be
@ -838,7 +838,7 @@ hashbucketcleanup(Relation rel, Bucket cur_bucket, Buffer bucket_buf,
} }
XLogRegisterBuffer(1, buf, REGBUF_STANDARD); XLogRegisterBuffer(1, buf, REGBUF_STANDARD);
XLogRegisterBufData(1, (char *) deletable, XLogRegisterBufData(1, deletable,
ndeletable * sizeof(OffsetNumber)); ndeletable * sizeof(OffsetNumber));
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_DELETE); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_DELETE);

8
src/backend/access/hash/hashinsert.c
View File

@ -221,12 +221,12 @@ restart_insert:
xlrec.offnum = itup_off; xlrec.offnum = itup_off;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashInsert); XLogRegisterData(&xlrec, SizeOfHashInsert);
XLogRegisterBuffer(1, metabuf, REGBUF_STANDARD); XLogRegisterBuffer(1, metabuf, REGBUF_STANDARD);
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterBufData(0, (char *) itup, IndexTupleSize(itup)); XLogRegisterBufData(0, itup, IndexTupleSize(itup));
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_INSERT); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_INSERT);
@ -436,14 +436,14 @@ _hash_vacuum_one_page(Relation rel, Relation hrel, Buffer metabuf, Buffer buf)
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterData((char *) &xlrec, SizeOfHashVacuumOnePage); XLogRegisterData(&xlrec, SizeOfHashVacuumOnePage);
/* /*
* We need the target-offsets array whether or not we store the * We need the target-offsets array whether or not we store the
* whole buffer, to allow us to find the snapshotConflictHorizon * whole buffer, to allow us to find the snapshotConflictHorizon
* on a standby server. * on a standby server.
*/ */
XLogRegisterData((char *) deletable, XLogRegisterData(deletable,
ndeletable * sizeof(OffsetNumber)); ndeletable * sizeof(OffsetNumber));
XLogRegisterBuffer(1, metabuf, REGBUF_STANDARD); XLogRegisterBuffer(1, metabuf, REGBUF_STANDARD);

26
src/backend/access/hash/hashovfl.c
View File

@ -388,24 +388,24 @@ found:
xlrec.bmsize = metap->hashm_bmsize; xlrec.bmsize = metap->hashm_bmsize;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashAddOvflPage); XLogRegisterData(&xlrec, SizeOfHashAddOvflPage);
XLogRegisterBuffer(0, ovflbuf, REGBUF_WILL_INIT); XLogRegisterBuffer(0, ovflbuf, REGBUF_WILL_INIT);
XLogRegisterBufData(0, (char *) &pageopaque->hasho_bucket, sizeof(Bucket)); XLogRegisterBufData(0, &pageopaque->hasho_bucket, sizeof(Bucket));
XLogRegisterBuffer(1, buf, REGBUF_STANDARD); XLogRegisterBuffer(1, buf, REGBUF_STANDARD);
if (BufferIsValid(mapbuf)) if (BufferIsValid(mapbuf))
{ {
XLogRegisterBuffer(2, mapbuf, REGBUF_STANDARD); XLogRegisterBuffer(2, mapbuf, REGBUF_STANDARD);
XLogRegisterBufData(2, (char *) &bitmap_page_bit, sizeof(uint32)); XLogRegisterBufData(2, &bitmap_page_bit, sizeof(uint32));
} }
if (BufferIsValid(newmapbuf)) if (BufferIsValid(newmapbuf))
XLogRegisterBuffer(3, newmapbuf, REGBUF_WILL_INIT); XLogRegisterBuffer(3, newmapbuf, REGBUF_WILL_INIT);
XLogRegisterBuffer(4, metabuf, REGBUF_STANDARD); XLogRegisterBuffer(4, metabuf, REGBUF_STANDARD);
XLogRegisterBufData(4, (char *) &metap->hashm_firstfree, sizeof(uint32)); XLogRegisterBufData(4, &metap->hashm_firstfree, sizeof(uint32));
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_ADD_OVFL_PAGE); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_ADD_OVFL_PAGE);
@ -656,7 +656,7 @@ _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf,
xlrec.is_prev_bucket_same_wrt = (wbuf == prevbuf); xlrec.is_prev_bucket_same_wrt = (wbuf == prevbuf);
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashSqueezePage); XLogRegisterData(&xlrec, SizeOfHashSqueezePage);
/* /*
* bucket buffer was not changed, but still needs to be registered to * bucket buffer was not changed, but still needs to be registered to
@ -676,10 +676,10 @@ _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf,
/* Remember that wbuf is modified. */ /* Remember that wbuf is modified. */
mod_wbuf = true; mod_wbuf = true;
XLogRegisterBufData(1, (char *) itup_offsets, XLogRegisterBufData(1, itup_offsets,
nitups * sizeof(OffsetNumber)); nitups * sizeof(OffsetNumber));
for (i = 0; i < nitups; i++) for (i = 0; i < nitups; i++)
XLogRegisterBufData(1, (char *) itups[i], tups_size[i]); XLogRegisterBufData(1, itups[i], tups_size[i]);
} }
else if (xlrec.is_prim_bucket_same_wrt || xlrec.is_prev_bucket_same_wrt) else if (xlrec.is_prim_bucket_same_wrt || xlrec.is_prev_bucket_same_wrt)
{ {
@ -721,12 +721,12 @@ _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf,
XLogRegisterBuffer(4, nextbuf, REGBUF_STANDARD); XLogRegisterBuffer(4, nextbuf, REGBUF_STANDARD);
XLogRegisterBuffer(5, mapbuf, REGBUF_STANDARD); XLogRegisterBuffer(5, mapbuf, REGBUF_STANDARD);
XLogRegisterBufData(5, (char *) &bitmapbit, sizeof(uint32)); XLogRegisterBufData(5, &bitmapbit, sizeof(uint32));
if (update_metap) if (update_metap)
{ {
XLogRegisterBuffer(6, metabuf, REGBUF_STANDARD); XLogRegisterBuffer(6, metabuf, REGBUF_STANDARD);
XLogRegisterBufData(6, (char *) &metap->hashm_firstfree, sizeof(uint32)); XLogRegisterBufData(6, &metap->hashm_firstfree, sizeof(uint32));
} }
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_SQUEEZE_PAGE); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_SQUEEZE_PAGE);
@ -993,7 +993,7 @@ readpage:
xlrec.is_prim_bucket_same_wrt = (wbuf == bucket_buf); xlrec.is_prim_bucket_same_wrt = (wbuf == bucket_buf);
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashMovePageContents); XLogRegisterData(&xlrec, SizeOfHashMovePageContents);
/* /*
* bucket buffer was not changed, but still needs to * bucket buffer was not changed, but still needs to
@ -1008,13 +1008,13 @@ readpage:
} }
XLogRegisterBuffer(1, wbuf, REGBUF_STANDARD); XLogRegisterBuffer(1, wbuf, REGBUF_STANDARD);
XLogRegisterBufData(1, (char *) itup_offsets, XLogRegisterBufData(1, itup_offsets,
nitups * sizeof(OffsetNumber)); nitups * sizeof(OffsetNumber));
for (i = 0; i < nitups; i++) for (i = 0; i < nitups; i++)
XLogRegisterBufData(1, (char *) itups[i], tups_size[i]); XLogRegisterBufData(1, itups[i], tups_size[i]);
XLogRegisterBuffer(2, rbuf, REGBUF_STANDARD); XLogRegisterBuffer(2, rbuf, REGBUF_STANDARD);
XLogRegisterBufData(2, (char *) deletable, XLogRegisterBufData(2, deletable,
ndeletable * sizeof(OffsetNumber)); ndeletable * sizeof(OffsetNumber));
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_MOVE_PAGE_CONTENTS); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_MOVE_PAGE_CONTENTS);

16
src/backend/access/hash/hashpage.c
View File

@ -394,7 +394,7 @@ _hash_init(Relation rel, double num_tuples, ForkNumber forkNum)
xlrec.ffactor = metap->hashm_ffactor; xlrec.ffactor = metap->hashm_ffactor;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashInitMetaPage); XLogRegisterData(&xlrec, SizeOfHashInitMetaPage);
XLogRegisterBuffer(0, metabuf, REGBUF_WILL_INIT | REGBUF_STANDARD); XLogRegisterBuffer(0, metabuf, REGBUF_WILL_INIT | REGBUF_STANDARD);
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_INIT_META_PAGE); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_INIT_META_PAGE);
@ -468,7 +468,7 @@ _hash_init(Relation rel, double num_tuples, ForkNumber forkNum)
xlrec.bmsize = metap->hashm_bmsize; xlrec.bmsize = metap->hashm_bmsize;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashInitBitmapPage); XLogRegisterData(&xlrec, SizeOfHashInitBitmapPage);
XLogRegisterBuffer(0, bitmapbuf, REGBUF_WILL_INIT); XLogRegisterBuffer(0, bitmapbuf, REGBUF_WILL_INIT);
/* /*
@ -916,21 +916,21 @@ restart_expand:
if (metap_update_masks) if (metap_update_masks)
{ {
xlrec.flags |= XLH_SPLIT_META_UPDATE_MASKS; xlrec.flags |= XLH_SPLIT_META_UPDATE_MASKS;
XLogRegisterBufData(2, (char *) &metap->hashm_lowmask, sizeof(uint32)); XLogRegisterBufData(2, &metap->hashm_lowmask, sizeof(uint32));
XLogRegisterBufData(2, (char *) &metap->hashm_highmask, sizeof(uint32)); XLogRegisterBufData(2, &metap->hashm_highmask, sizeof(uint32));
} }
if (metap_update_splitpoint) if (metap_update_splitpoint)
{ {
xlrec.flags |= XLH_SPLIT_META_UPDATE_SPLITPOINT; xlrec.flags |= XLH_SPLIT_META_UPDATE_SPLITPOINT;
XLogRegisterBufData(2, (char *) &metap->hashm_ovflpoint, XLogRegisterBufData(2, &metap->hashm_ovflpoint,
sizeof(uint32)); sizeof(uint32));
XLogRegisterBufData(2, XLogRegisterBufData(2,
(char *) &metap->hashm_spares[metap->hashm_ovflpoint], &metap->hashm_spares[metap->hashm_ovflpoint],
sizeof(uint32)); sizeof(uint32));
} }
XLogRegisterData((char *) &xlrec, SizeOfHashSplitAllocPage); XLogRegisterData(&xlrec, SizeOfHashSplitAllocPage);
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_SPLIT_ALLOCATE_PAGE); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_SPLIT_ALLOCATE_PAGE);
@ -1304,7 +1304,7 @@ _hash_splitbucket(Relation rel,
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHashSplitComplete); XLogRegisterData(&xlrec, SizeOfHashSplitComplete);
XLogRegisterBuffer(0, bucket_obuf, REGBUF_STANDARD); XLogRegisterBuffer(0, bucket_obuf, REGBUF_STANDARD);
XLogRegisterBuffer(1, bucket_nbuf, REGBUF_STANDARD); XLogRegisterBuffer(1, bucket_nbuf, REGBUF_STANDARD);

46
src/backend/access/heap/heapam.c
View File

@ -2133,7 +2133,7 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
} }
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHeapInsert); XLogRegisterData(&xlrec, SizeOfHeapInsert);
xlhdr.t_infomask2 = heaptup->t_data->t_infomask2; xlhdr.t_infomask2 = heaptup->t_data->t_infomask2;
xlhdr.t_infomask = heaptup->t_data->t_infomask; xlhdr.t_infomask = heaptup->t_data->t_infomask;
@ -2145,7 +2145,7 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
* xl_heap_header in the xlog. * xl_heap_header in the xlog.
*/ */
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD | bufflags); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD | bufflags);
XLogRegisterBufData(0, (char *) &xlhdr, SizeOfHeapHeader); XLogRegisterBufData(0, &xlhdr, SizeOfHeapHeader);
/* PG73FORMAT: write bitmap [+ padding] [+ oid] + data */ /* PG73FORMAT: write bitmap [+ padding] [+ oid] + data */
XLogRegisterBufData(0, XLogRegisterBufData(0,
(char *) heaptup->t_data + SizeofHeapTupleHeader, (char *) heaptup->t_data + SizeofHeapTupleHeader,
@ -2542,7 +2542,7 @@ heap_multi_insert(Relation relation, TupleTableSlot **slots, int ntuples,
bufflags |= REGBUF_KEEP_DATA; bufflags |= REGBUF_KEEP_DATA;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) xlrec, tupledata - scratch.data); XLogRegisterData(xlrec, tupledata - scratch.data);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD | bufflags); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD | bufflags);
XLogRegisterBufData(0, tupledata, totaldatalen); XLogRegisterBufData(0, tupledata, totaldatalen);
@ -3032,7 +3032,7 @@ l1:
} }
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHeapDelete); XLogRegisterData(&xlrec, SizeOfHeapDelete);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);
@ -3045,7 +3045,7 @@ l1:
xlhdr.t_infomask = old_key_tuple->t_data->t_infomask; xlhdr.t_infomask = old_key_tuple->t_data->t_infomask;
xlhdr.t_hoff = old_key_tuple->t_data->t_hoff; xlhdr.t_hoff = old_key_tuple->t_data->t_hoff;
XLogRegisterData((char *) &xlhdr, SizeOfHeapHeader); XLogRegisterData(&xlhdr, SizeOfHeapHeader);
XLogRegisterData((char *) old_key_tuple->t_data XLogRegisterData((char *) old_key_tuple->t_data
+ SizeofHeapTupleHeader, + SizeofHeapTupleHeader,
old_key_tuple->t_len old_key_tuple->t_len
@ -3811,7 +3811,7 @@ l2:
oldtup.t_data->t_infomask2); oldtup.t_data->t_infomask2);
xlrec.flags = xlrec.flags =
cleared_all_frozen ? XLH_LOCK_ALL_FROZEN_CLEARED : 0; cleared_all_frozen ? XLH_LOCK_ALL_FROZEN_CLEARED : 0;
XLogRegisterData((char *) &xlrec, SizeOfHeapLock); XLogRegisterData(&xlrec, SizeOfHeapLock);
recptr = XLogInsert(RM_HEAP_ID, XLOG_HEAP_LOCK); recptr = XLogInsert(RM_HEAP_ID, XLOG_HEAP_LOCK);
PageSetLSN(page, recptr); PageSetLSN(page, recptr);
} }
@ -5142,7 +5142,7 @@ failed:
xlrec.infobits_set = compute_infobits(new_infomask, xlrec.infobits_set = compute_infobits(new_infomask,
tuple->t_data->t_infomask2); tuple->t_data->t_infomask2);
xlrec.flags = cleared_all_frozen ? XLH_LOCK_ALL_FROZEN_CLEARED : 0; xlrec.flags = cleared_all_frozen ? XLH_LOCK_ALL_FROZEN_CLEARED : 0;
XLogRegisterData((char *) &xlrec, SizeOfHeapLock); XLogRegisterData(&xlrec, SizeOfHeapLock);
/* we don't decode row locks atm, so no need to log the origin */ /* we don't decode row locks atm, so no need to log the origin */
@ -5895,7 +5895,7 @@ l4:
xlrec.flags = xlrec.flags =
cleared_all_frozen ? XLH_LOCK_ALL_FROZEN_CLEARED : 0; cleared_all_frozen ? XLH_LOCK_ALL_FROZEN_CLEARED : 0;
XLogRegisterData((char *) &xlrec, SizeOfHeapLockUpdated); XLogRegisterData(&xlrec, SizeOfHeapLockUpdated);
recptr = XLogInsert(RM_HEAP2_ID, XLOG_HEAP2_LOCK_UPDATED); recptr = XLogInsert(RM_HEAP2_ID, XLOG_HEAP2_LOCK_UPDATED);
@ -6048,7 +6048,7 @@ heap_finish_speculative(Relation relation, ItemPointer tid)
/* We want the same filtering on this as on a plain insert */ /* We want the same filtering on this as on a plain insert */
XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN); XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN);
XLogRegisterData((char *) &xlrec, SizeOfHeapConfirm); XLogRegisterData(&xlrec, SizeOfHeapConfirm);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);
recptr = XLogInsert(RM_HEAP_ID, XLOG_HEAP_CONFIRM); recptr = XLogInsert(RM_HEAP_ID, XLOG_HEAP_CONFIRM);
@ -6193,7 +6193,7 @@ heap_abort_speculative(Relation relation, ItemPointer tid)
xlrec.xmax = xid; xlrec.xmax = xid;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHeapDelete); XLogRegisterData(&xlrec, SizeOfHeapDelete);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);
/* No replica identity & replication origin logged */ /* No replica identity & replication origin logged */
@ -6489,9 +6489,9 @@ heap_inplace_update_and_unlock(Relation relation,
xlrec.nmsgs = nmsgs; xlrec.nmsgs = nmsgs;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, MinSizeOfHeapInplace); XLogRegisterData(&xlrec, MinSizeOfHeapInplace);
if (nmsgs != 0) if (nmsgs != 0)
XLogRegisterData((char *) invalMessages, XLogRegisterData(invalMessages,
nmsgs * sizeof(SharedInvalidationMessage)); nmsgs * sizeof(SharedInvalidationMessage));
/* register block matching what buffer will look like after changes */ /* register block matching what buffer will look like after changes */
@ -8722,7 +8722,7 @@ log_heap_visible(Relation rel, Buffer heap_buffer, Buffer vm_buffer,
if (RelationIsAccessibleInLogicalDecoding(rel)) if (RelationIsAccessibleInLogicalDecoding(rel))
xlrec.flags |= VISIBILITYMAP_XLOG_CATALOG_REL; xlrec.flags |= VISIBILITYMAP_XLOG_CATALOG_REL;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHeapVisible); XLogRegisterData(&xlrec, SizeOfHeapVisible);
XLogRegisterBuffer(0, vm_buffer, 0); XLogRegisterBuffer(0, vm_buffer, 0);
@ -8873,7 +8873,7 @@ log_heap_update(Relation reln, Buffer oldbuf,
if (oldbuf != newbuf) if (oldbuf != newbuf)
XLogRegisterBuffer(1, oldbuf, REGBUF_STANDARD); XLogRegisterBuffer(1, oldbuf, REGBUF_STANDARD);
XLogRegisterData((char *) &xlrec, SizeOfHeapUpdate); XLogRegisterData(&xlrec, SizeOfHeapUpdate);
/* /*
* Prepare WAL data for the new tuple. * Prepare WAL data for the new tuple.
@ -8884,15 +8884,15 @@ log_heap_update(Relation reln, Buffer oldbuf,
{ {
prefix_suffix[0] = prefixlen; prefix_suffix[0] = prefixlen;
prefix_suffix[1] = suffixlen; prefix_suffix[1] = suffixlen;
XLogRegisterBufData(0, (char *) &prefix_suffix, sizeof(uint16) * 2); XLogRegisterBufData(0, &prefix_suffix, sizeof(uint16) * 2);
} }
else if (prefixlen > 0) else if (prefixlen > 0)
{ {
XLogRegisterBufData(0, (char *) &prefixlen, sizeof(uint16)); XLogRegisterBufData(0, &prefixlen, sizeof(uint16));
} }
else else
{ {
XLogRegisterBufData(0, (char *) &suffixlen, sizeof(uint16)); XLogRegisterBufData(0, &suffixlen, sizeof(uint16));
} }
} }
@ -8906,11 +8906,11 @@ log_heap_update(Relation reln, Buffer oldbuf,
* *
* The 'data' doesn't include the common prefix or suffix. * The 'data' doesn't include the common prefix or suffix.
*/ */
XLogRegisterBufData(0, (char *) &xlhdr, SizeOfHeapHeader); XLogRegisterBufData(0, &xlhdr, SizeOfHeapHeader);
if (prefixlen == 0) if (prefixlen == 0)
{ {
XLogRegisterBufData(0, XLogRegisterBufData(0,
((char *) newtup->t_data) + SizeofHeapTupleHeader, (char *) newtup->t_data + SizeofHeapTupleHeader,
newtup->t_len - SizeofHeapTupleHeader - suffixlen); newtup->t_len - SizeofHeapTupleHeader - suffixlen);
} }
else else
@ -8923,13 +8923,13 @@ log_heap_update(Relation reln, Buffer oldbuf,
if (newtup->t_data->t_hoff - SizeofHeapTupleHeader > 0) if (newtup->t_data->t_hoff - SizeofHeapTupleHeader > 0)
{ {
XLogRegisterBufData(0, XLogRegisterBufData(0,
((char *) newtup->t_data) + SizeofHeapTupleHeader, (char *) newtup->t_data + SizeofHeapTupleHeader,
newtup->t_data->t_hoff - SizeofHeapTupleHeader); newtup->t_data->t_hoff - SizeofHeapTupleHeader);
} }
/* data after common prefix */ /* data after common prefix */
XLogRegisterBufData(0, XLogRegisterBufData(0,
((char *) newtup->t_data) + newtup->t_data->t_hoff + prefixlen, (char *) newtup->t_data + newtup->t_data->t_hoff + prefixlen,
newtup->t_len - newtup->t_data->t_hoff - prefixlen - suffixlen); newtup->t_len - newtup->t_data->t_hoff - prefixlen - suffixlen);
} }
@ -8941,7 +8941,7 @@ log_heap_update(Relation reln, Buffer oldbuf,
xlhdr_idx.t_infomask = old_key_tuple->t_data->t_infomask; xlhdr_idx.t_infomask = old_key_tuple->t_data->t_infomask;
xlhdr_idx.t_hoff = old_key_tuple->t_data->t_hoff; xlhdr_idx.t_hoff = old_key_tuple->t_data->t_hoff;
XLogRegisterData((char *) &xlhdr_idx, SizeOfHeapHeader); XLogRegisterData(&xlhdr_idx, SizeOfHeapHeader);
/* PG73FORMAT: write bitmap [+ padding] [+ oid] + data */ /* PG73FORMAT: write bitmap [+ padding] [+ oid] + data */
XLogRegisterData((char *) old_key_tuple->t_data + SizeofHeapTupleHeader, XLogRegisterData((char *) old_key_tuple->t_data + SizeofHeapTupleHeader,
@ -9021,7 +9021,7 @@ log_heap_new_cid(Relation relation, HeapTuple tup)
* called us certainly did, but that's WAL-logged separately. * called us certainly did, but that's WAL-logged separately.
*/ */
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHeapNewCid); XLogRegisterData(&xlrec, SizeOfHeapNewCid);
/* will be looked at irrespective of origin */ /* will be looked at irrespective of origin */

22
src/backend/access/heap/pruneheap.c
View File

@ -2093,9 +2093,9 @@ log_heap_prune_and_freeze(Relation relation, Buffer buffer,
nplans = heap_log_freeze_plan(frozen, nfrozen, plans, frz_offsets); nplans = heap_log_freeze_plan(frozen, nfrozen, plans, frz_offsets);
freeze_plans.nplans = nplans; freeze_plans.nplans = nplans;
XLogRegisterBufData(0, (char *) &freeze_plans, XLogRegisterBufData(0, &freeze_plans,
offsetof(xlhp_freeze_plans, plans)); offsetof(xlhp_freeze_plans, plans));
XLogRegisterBufData(0, (char *) plans, XLogRegisterBufData(0, plans,
sizeof(xlhp_freeze_plan) * nplans); sizeof(xlhp_freeze_plan) * nplans);
} }
if (nredirected > 0) if (nredirected > 0)
@ -2103,9 +2103,9 @@ log_heap_prune_and_freeze(Relation relation, Buffer buffer,
xlrec.flags |= XLHP_HAS_REDIRECTIONS; xlrec.flags |= XLHP_HAS_REDIRECTIONS;
redirect_items.ntargets = nredirected; redirect_items.ntargets = nredirected;
XLogRegisterBufData(0, (char *) &redirect_items, XLogRegisterBufData(0, &redirect_items,
offsetof(xlhp_prune_items, data)); offsetof(xlhp_prune_items, data));
XLogRegisterBufData(0, (char *) redirected, XLogRegisterBufData(0, redirected,
sizeof(OffsetNumber[2]) * nredirected); sizeof(OffsetNumber[2]) * nredirected);
} }
if (ndead > 0) if (ndead > 0)
@ -2113,9 +2113,9 @@ log_heap_prune_and_freeze(Relation relation, Buffer buffer,
xlrec.flags |= XLHP_HAS_DEAD_ITEMS; xlrec.flags |= XLHP_HAS_DEAD_ITEMS;
dead_items.ntargets = ndead; dead_items.ntargets = ndead;
XLogRegisterBufData(0, (char *) &dead_items, XLogRegisterBufData(0, &dead_items,
offsetof(xlhp_prune_items, data)); offsetof(xlhp_prune_items, data));
XLogRegisterBufData(0, (char *) dead, XLogRegisterBufData(0, dead,
sizeof(OffsetNumber) * ndead); sizeof(OffsetNumber) * ndead);
} }
if (nunused > 0) if (nunused > 0)
@ -2123,13 +2123,13 @@ log_heap_prune_and_freeze(Relation relation, Buffer buffer,
xlrec.flags |= XLHP_HAS_NOW_UNUSED_ITEMS; xlrec.flags |= XLHP_HAS_NOW_UNUSED_ITEMS;
unused_items.ntargets = nunused; unused_items.ntargets = nunused;
XLogRegisterBufData(0, (char *) &unused_items, XLogRegisterBufData(0, &unused_items,
offsetof(xlhp_prune_items, data)); offsetof(xlhp_prune_items, data));
XLogRegisterBufData(0, (char *) unused, XLogRegisterBufData(0, unused,
sizeof(OffsetNumber) * nunused); sizeof(OffsetNumber) * nunused);
} }
if (nfrozen > 0) if (nfrozen > 0)
XLogRegisterBufData(0, (char *) frz_offsets, XLogRegisterBufData(0, frz_offsets,
sizeof(OffsetNumber) * nfrozen); sizeof(OffsetNumber) * nfrozen);
/* /*
@ -2147,9 +2147,9 @@ log_heap_prune_and_freeze(Relation relation, Buffer buffer,
Assert(nredirected == 0 && ndead == 0); Assert(nredirected == 0 && ndead == 0);
/* also, any items in 'unused' must've been LP_DEAD previously */ /* also, any items in 'unused' must've been LP_DEAD previously */
} }
XLogRegisterData((char *) &xlrec, SizeOfHeapPrune); XLogRegisterData(&xlrec, SizeOfHeapPrune);
if (TransactionIdIsValid(conflict_xid)) if (TransactionIdIsValid(conflict_xid))
XLogRegisterData((char *) &conflict_xid, sizeof(TransactionId)); XLogRegisterData(&conflict_xid, sizeof(TransactionId));
switch (reason) switch (reason)
{ {

2
src/backend/access/heap/rewriteheap.c
View File

@ -887,7 +887,7 @@ logical_heap_rewrite_flush_mappings(RewriteState state)
src->off += len; src->off += len;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogRegisterData(waldata_start, len); XLogRegisterData(waldata_start, len);
/* write xlog record */ /* write xlog record */

4
src/backend/access/nbtree/nbtdedup.c
View File

@ -252,14 +252,14 @@ _bt_dedup_pass(Relation rel, Buffer buf, IndexTuple newitem, Size newitemsz,
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterData((char *) &xlrec_dedup, SizeOfBtreeDedup); XLogRegisterData(&xlrec_dedup, SizeOfBtreeDedup);
/* /*
* The intervals array is not in the buffer, but pretend that it is. * The intervals array is not in the buffer, but pretend that it is.
* When XLogInsert stores the whole buffer, the array need not be * When XLogInsert stores the whole buffer, the array need not be
* stored too. * stored too.
*/ */
XLogRegisterBufData(0, (char *) state->intervals, XLogRegisterBufData(0, state->intervals,
state->nintervals * sizeof(BTDedupInterval)); state->nintervals * sizeof(BTDedupInterval));
recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_DEDUP); recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_DEDUP);

22
src/backend/access/nbtree/nbtinsert.c
View File

@ -1320,7 +1320,7 @@ _bt_insertonpg(Relation rel,
xlrec.offnum = newitemoff; xlrec.offnum = newitemoff;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBtreeInsert); XLogRegisterData(&xlrec, SizeOfBtreeInsert);
if (isleaf && postingoff == 0) if (isleaf && postingoff == 0)
{ {
@ -1358,7 +1358,7 @@ _bt_insertonpg(Relation rel,
XLogRegisterBuffer(2, metabuf, XLogRegisterBuffer(2, metabuf,
REGBUF_WILL_INIT | REGBUF_STANDARD); REGBUF_WILL_INIT | REGBUF_STANDARD);
XLogRegisterBufData(2, (char *) &xlmeta, XLogRegisterBufData(2, &xlmeta,
sizeof(xl_btree_metadata)); sizeof(xl_btree_metadata));
} }
} }
@ -1367,7 +1367,7 @@ _bt_insertonpg(Relation rel,
if (postingoff == 0) if (postingoff == 0)
{ {
/* Just log itup from caller */ /* Just log itup from caller */
XLogRegisterBufData(0, (char *) itup, IndexTupleSize(itup)); XLogRegisterBufData(0, itup, IndexTupleSize(itup));
} }
else else
{ {
@ -1381,8 +1381,8 @@ _bt_insertonpg(Relation rel,
*/ */
upostingoff = postingoff; upostingoff = postingoff;
XLogRegisterBufData(0, (char *) &upostingoff, sizeof(uint16)); XLogRegisterBufData(0, &upostingoff, sizeof(uint16));
XLogRegisterBufData(0, (char *) origitup, XLogRegisterBufData(0, origitup,
IndexTupleSize(origitup)); IndexTupleSize(origitup));
} }
@ -1979,7 +1979,7 @@ _bt_split(Relation rel, Relation heaprel, BTScanInsert itup_key, Buffer buf,
xlrec.postingoff = postingoff; xlrec.postingoff = postingoff;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBtreeSplit); XLogRegisterData(&xlrec, SizeOfBtreeSplit);
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterBuffer(1, rbuf, REGBUF_WILL_INIT); XLogRegisterBuffer(1, rbuf, REGBUF_WILL_INIT);
@ -2017,13 +2017,13 @@ _bt_split(Relation rel, Relation heaprel, BTScanInsert itup_key, Buffer buf,
* newitem-logged case). * newitem-logged case).
*/ */
if (newitemonleft && xlrec.postingoff == 0) if (newitemonleft && xlrec.postingoff == 0)
XLogRegisterBufData(0, (char *) newitem, newitemsz); XLogRegisterBufData(0, newitem, newitemsz);
else if (xlrec.postingoff != 0) else if (xlrec.postingoff != 0)
{ {
Assert(isleaf); Assert(isleaf);
Assert(newitemonleft || firstrightoff == newitemoff); Assert(newitemonleft || firstrightoff == newitemoff);
Assert(newitemsz == IndexTupleSize(orignewitem)); Assert(newitemsz == IndexTupleSize(orignewitem));
XLogRegisterBufData(0, (char *) orignewitem, newitemsz); XLogRegisterBufData(0, orignewitem, newitemsz);
} }
/* Log the left page's new high key */ /* Log the left page's new high key */
@ -2033,7 +2033,7 @@ _bt_split(Relation rel, Relation heaprel, BTScanInsert itup_key, Buffer buf,
itemid = PageGetItemId(origpage, P_HIKEY); itemid = PageGetItemId(origpage, P_HIKEY);
lefthighkey = (IndexTuple) PageGetItem(origpage, itemid); lefthighkey = (IndexTuple) PageGetItem(origpage, itemid);
} }
XLogRegisterBufData(0, (char *) lefthighkey, XLogRegisterBufData(0, lefthighkey,
MAXALIGN(IndexTupleSize(lefthighkey))); MAXALIGN(IndexTupleSize(lefthighkey)));
/* /*
@ -2564,7 +2564,7 @@ _bt_newlevel(Relation rel, Relation heaprel, Buffer lbuf, Buffer rbuf)
xlrec.level = metad->btm_level; xlrec.level = metad->btm_level;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfBtreeNewroot); XLogRegisterData(&xlrec, SizeOfBtreeNewroot);
XLogRegisterBuffer(0, rootbuf, REGBUF_WILL_INIT); XLogRegisterBuffer(0, rootbuf, REGBUF_WILL_INIT);
XLogRegisterBuffer(1, lbuf, REGBUF_STANDARD); XLogRegisterBuffer(1, lbuf, REGBUF_STANDARD);
@ -2579,7 +2579,7 @@ _bt_newlevel(Relation rel, Relation heaprel, Buffer lbuf, Buffer rbuf)
md.last_cleanup_num_delpages = metad->btm_last_cleanup_num_delpages; md.last_cleanup_num_delpages = metad->btm_last_cleanup_num_delpages;
md.allequalimage = metad->btm_allequalimage; md.allequalimage = metad->btm_allequalimage;
XLogRegisterBufData(2, (char *) &md, sizeof(xl_btree_metadata)); XLogRegisterBufData(2, &md, sizeof(xl_btree_metadata));
/* /*
* Direct access to page is not good but faster - we should implement * Direct access to page is not good but faster - we should implement

26
src/backend/access/nbtree/nbtpage.c
View File

@ -299,7 +299,7 @@ _bt_set_cleanup_info(Relation rel, BlockNumber num_delpages)
md.last_cleanup_num_delpages = num_delpages; md.last_cleanup_num_delpages = num_delpages;
md.allequalimage = metad->btm_allequalimage; md.allequalimage = metad->btm_allequalimage;
XLogRegisterBufData(0, (char *) &md, sizeof(xl_btree_metadata)); XLogRegisterBufData(0, &md, sizeof(xl_btree_metadata));
recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_META_CLEANUP); recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_META_CLEANUP);
@ -488,12 +488,12 @@ _bt_getroot(Relation rel, Relation heaprel, int access)
md.last_cleanup_num_delpages = 0; md.last_cleanup_num_delpages = 0;
md.allequalimage = metad->btm_allequalimage; md.allequalimage = metad->btm_allequalimage;
XLogRegisterBufData(2, (char *) &md, sizeof(xl_btree_metadata)); XLogRegisterBufData(2, &md, sizeof(xl_btree_metadata));
xlrec.rootblk = rootblkno; xlrec.rootblk = rootblkno;
xlrec.level = 0; xlrec.level = 0;
XLogRegisterData((char *) &xlrec, SizeOfBtreeNewroot); XLogRegisterData(&xlrec, SizeOfBtreeNewroot);
recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_NEWROOT); recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_NEWROOT);
@ -948,7 +948,7 @@ _bt_allocbuf(Relation rel, Relation heaprel)
RelationIsAccessibleInLogicalDecoding(heaprel); RelationIsAccessibleInLogicalDecoding(heaprel);
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec_reuse, SizeOfBtreeReusePage); XLogRegisterData(&xlrec_reuse, SizeOfBtreeReusePage);
XLogInsert(RM_BTREE_ID, XLOG_BTREE_REUSE_PAGE); XLogInsert(RM_BTREE_ID, XLOG_BTREE_REUSE_PAGE);
} }
@ -1234,15 +1234,15 @@ _bt_delitems_vacuum(Relation rel, Buffer buf,
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterData((char *) &xlrec_vacuum, SizeOfBtreeVacuum); XLogRegisterData(&xlrec_vacuum, SizeOfBtreeVacuum);
if (ndeletable > 0) if (ndeletable > 0)
XLogRegisterBufData(0, (char *) deletable, XLogRegisterBufData(0, deletable,
ndeletable * sizeof(OffsetNumber)); ndeletable * sizeof(OffsetNumber));
if (nupdatable > 0) if (nupdatable > 0)
{ {
XLogRegisterBufData(0, (char *) updatedoffsets, XLogRegisterBufData(0, updatedoffsets,
nupdatable * sizeof(OffsetNumber)); nupdatable * sizeof(OffsetNumber));
XLogRegisterBufData(0, updatedbuf, updatedbuflen); XLogRegisterBufData(0, updatedbuf, updatedbuflen);
} }
@ -1353,15 +1353,15 @@ _bt_delitems_delete(Relation rel, Buffer buf,
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterBuffer(0, buf, REGBUF_STANDARD); XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
XLogRegisterData((char *) &xlrec_delete, SizeOfBtreeDelete); XLogRegisterData(&xlrec_delete, SizeOfBtreeDelete);
if (ndeletable > 0) if (ndeletable > 0)
XLogRegisterBufData(0, (char *) deletable, XLogRegisterBufData(0, deletable,
ndeletable * sizeof(OffsetNumber)); ndeletable * sizeof(OffsetNumber));
if (nupdatable > 0) if (nupdatable > 0)
{ {
XLogRegisterBufData(0, (char *) updatedoffsets, XLogRegisterBufData(0, updatedoffsets,
nupdatable * sizeof(OffsetNumber)); nupdatable * sizeof(OffsetNumber));
XLogRegisterBufData(0, updatedbuf, updatedbuflen); XLogRegisterBufData(0, updatedbuf, updatedbuflen);
} }
@ -2269,7 +2269,7 @@ _bt_mark_page_halfdead(Relation rel, Relation heaprel, Buffer leafbuf,
xlrec.leftblk = opaque->btpo_prev; xlrec.leftblk = opaque->btpo_prev;
xlrec.rightblk = opaque->btpo_next; xlrec.rightblk = opaque->btpo_next;
XLogRegisterData((char *) &xlrec, SizeOfBtreeMarkPageHalfDead); XLogRegisterData(&xlrec, SizeOfBtreeMarkPageHalfDead);
recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_MARK_PAGE_HALFDEAD); recptr = XLogInsert(RM_BTREE_ID, XLOG_BTREE_MARK_PAGE_HALFDEAD);
@ -2694,7 +2694,7 @@ _bt_unlink_halfdead_page(Relation rel, Buffer leafbuf, BlockNumber scanblkno,
xlrec.leafrightsib = leafrightsib; xlrec.leafrightsib = leafrightsib;
xlrec.leaftopparent = leaftopparent; xlrec.leaftopparent = leaftopparent;
XLogRegisterData((char *) &xlrec, SizeOfBtreeUnlinkPage); XLogRegisterData(&xlrec, SizeOfBtreeUnlinkPage);
if (BufferIsValid(metabuf)) if (BufferIsValid(metabuf))
{ {
@ -2709,7 +2709,7 @@ _bt_unlink_halfdead_page(Relation rel, Buffer leafbuf, BlockNumber scanblkno,
xlmeta.last_cleanup_num_delpages = metad->btm_last_cleanup_num_delpages; xlmeta.last_cleanup_num_delpages = metad->btm_last_cleanup_num_delpages;
xlmeta.allequalimage = metad->btm_allequalimage; xlmeta.allequalimage = metad->btm_allequalimage;
XLogRegisterBufData(4, (char *) &xlmeta, sizeof(xl_btree_metadata)); XLogRegisterBufData(4, &xlmeta, sizeof(xl_btree_metadata));
xlinfo = XLOG_BTREE_UNLINK_PAGE_META; xlinfo = XLOG_BTREE_UNLINK_PAGE_META;
} }
else else

36
src/backend/access/spgist/spgdoinsert.c
View File

@ -295,8 +295,8 @@ addLeafTuple(Relation index, SpGistState *state, SpGistLeafTuple leafTuple,
int flags; int flags;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogRegisterData((char *) leafTuple, leafTuple->size); XLogRegisterData(leafTuple, leafTuple->size);
flags = REGBUF_STANDARD; flags = REGBUF_STANDARD;
if (xlrec.newPage) if (xlrec.newPage)
@ -532,12 +532,12 @@ moveLeafs(Relation index, SpGistState *state,
xlrec.nodeI = parent->node; xlrec.nodeI = parent->node;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfSpgxlogMoveLeafs); XLogRegisterData(&xlrec, SizeOfSpgxlogMoveLeafs);
XLogRegisterData((char *) toDelete, XLogRegisterData(toDelete,
sizeof(OffsetNumber) * nDelete); sizeof(OffsetNumber) * nDelete);
XLogRegisterData((char *) toInsert, XLogRegisterData(toInsert,
sizeof(OffsetNumber) * nInsert); sizeof(OffsetNumber) * nInsert);
XLogRegisterData((char *) leafdata, leafptr - leafdata); XLogRegisterData(leafdata, leafptr - leafdata);
XLogRegisterBuffer(0, current->buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, current->buffer, REGBUF_STANDARD);
XLogRegisterBuffer(1, nbuf, REGBUF_STANDARD | (xlrec.newPage ? REGBUF_WILL_INIT : 0)); XLogRegisterBuffer(1, nbuf, REGBUF_STANDARD | (xlrec.newPage ? REGBUF_WILL_INIT : 0));
@ -1365,15 +1365,15 @@ doPickSplit(Relation index, SpGistState *state,
XLogBeginInsert(); XLogBeginInsert();
xlrec.nInsert = nToInsert; xlrec.nInsert = nToInsert;
XLogRegisterData((char *) &xlrec, SizeOfSpgxlogPickSplit); XLogRegisterData(&xlrec, SizeOfSpgxlogPickSplit);
XLogRegisterData((char *) toDelete, XLogRegisterData(toDelete,
sizeof(OffsetNumber) * xlrec.nDelete); sizeof(OffsetNumber) * xlrec.nDelete);
XLogRegisterData((char *) toInsert, XLogRegisterData(toInsert,
sizeof(OffsetNumber) * xlrec.nInsert); sizeof(OffsetNumber) * xlrec.nInsert);
XLogRegisterData((char *) leafPageSelect, XLogRegisterData(leafPageSelect,
sizeof(uint8) * xlrec.nInsert); sizeof(uint8) * xlrec.nInsert);
XLogRegisterData((char *) innerTuple, innerTuple->size); XLogRegisterData(innerTuple, innerTuple->size);
XLogRegisterData(leafdata, leafptr - leafdata); XLogRegisterData(leafdata, leafptr - leafdata);
/* Old leaf page */ /* Old leaf page */
@ -1559,8 +1559,8 @@ spgAddNodeAction(Relation index, SpGistState *state,
XLogRecPtr recptr; XLogRecPtr recptr;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogRegisterData((char *) newInnerTuple, newInnerTuple->size); XLogRegisterData(newInnerTuple, newInnerTuple->size);
XLogRegisterBuffer(0, current->buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, current->buffer, REGBUF_STANDARD);
@ -1685,8 +1685,8 @@ spgAddNodeAction(Relation index, SpGistState *state,
if (xlrec.parentBlk == 2) if (xlrec.parentBlk == 2)
XLogRegisterBuffer(2, parent->buffer, REGBUF_STANDARD); XLogRegisterBuffer(2, parent->buffer, REGBUF_STANDARD);
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogRegisterData((char *) newInnerTuple, newInnerTuple->size); XLogRegisterData(newInnerTuple, newInnerTuple->size);
recptr = XLogInsert(RM_SPGIST_ID, XLOG_SPGIST_ADD_NODE); recptr = XLogInsert(RM_SPGIST_ID, XLOG_SPGIST_ADD_NODE);
@ -1868,9 +1868,9 @@ spgSplitNodeAction(Relation index, SpGistState *state,
XLogRecPtr recptr; XLogRecPtr recptr;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogRegisterData((char *) prefixTuple, prefixTuple->size); XLogRegisterData(prefixTuple, prefixTuple->size);
XLogRegisterData((char *) postfixTuple, postfixTuple->size); XLogRegisterData(postfixTuple, postfixTuple->size);
XLogRegisterBuffer(0, current->buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, current->buffer, REGBUF_STANDARD);
if (newBuffer != InvalidBuffer) if (newBuffer != InvalidBuffer)

22
src/backend/access/spgist/spgvacuum.c
View File

@ -380,14 +380,14 @@ vacuumLeafPage(spgBulkDeleteState *bds, Relation index, Buffer buffer,
STORE_STATE(&bds->spgstate, xlrec.stateSrc); STORE_STATE(&bds->spgstate, xlrec.stateSrc);
XLogRegisterData((char *) &xlrec, SizeOfSpgxlogVacuumLeaf); XLogRegisterData(&xlrec, SizeOfSpgxlogVacuumLeaf);
/* sizeof(xlrec) should be a multiple of sizeof(OffsetNumber) */ /* sizeof(xlrec) should be a multiple of sizeof(OffsetNumber) */
XLogRegisterData((char *) toDead, sizeof(OffsetNumber) * xlrec.nDead); XLogRegisterData(toDead, sizeof(OffsetNumber) * xlrec.nDead);
XLogRegisterData((char *) toPlaceholder, sizeof(OffsetNumber) * xlrec.nPlaceholder); XLogRegisterData(toPlaceholder, sizeof(OffsetNumber) * xlrec.nPlaceholder);
XLogRegisterData((char *) moveSrc, sizeof(OffsetNumber) * xlrec.nMove); XLogRegisterData(moveSrc, sizeof(OffsetNumber) * xlrec.nMove);
XLogRegisterData((char *) moveDest, sizeof(OffsetNumber) * xlrec.nMove); XLogRegisterData(moveDest, sizeof(OffsetNumber) * xlrec.nMove);
XLogRegisterData((char *) chainSrc, sizeof(OffsetNumber) * xlrec.nChain); XLogRegisterData(chainSrc, sizeof(OffsetNumber) * xlrec.nChain);
XLogRegisterData((char *) chainDest, sizeof(OffsetNumber) * xlrec.nChain); XLogRegisterData(chainDest, sizeof(OffsetNumber) * xlrec.nChain);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);
@ -465,9 +465,9 @@ vacuumLeafRoot(spgBulkDeleteState *bds, Relation index, Buffer buffer)
/* Prepare WAL record */ /* Prepare WAL record */
STORE_STATE(&bds->spgstate, xlrec.stateSrc); STORE_STATE(&bds->spgstate, xlrec.stateSrc);
XLogRegisterData((char *) &xlrec, SizeOfSpgxlogVacuumRoot); XLogRegisterData(&xlrec, SizeOfSpgxlogVacuumRoot);
/* sizeof(xlrec) should be a multiple of sizeof(OffsetNumber) */ /* sizeof(xlrec) should be a multiple of sizeof(OffsetNumber) */
XLogRegisterData((char *) toDelete, XLogRegisterData(toDelete,
sizeof(OffsetNumber) * xlrec.nDelete); sizeof(OffsetNumber) * xlrec.nDelete);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);
@ -600,8 +600,8 @@ vacuumRedirectAndPlaceholder(Relation index, Relation heaprel, Buffer buffer)
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfSpgxlogVacuumRedirect); XLogRegisterData(&xlrec, SizeOfSpgxlogVacuumRedirect);
XLogRegisterData((char *) itemToPlaceholder, XLogRegisterData(itemToPlaceholder,
sizeof(OffsetNumber) * xlrec.nToPlaceholder); sizeof(OffsetNumber) * xlrec.nToPlaceholder);
XLogRegisterBuffer(0, buffer, REGBUF_STANDARD); XLogRegisterBuffer(0, buffer, REGBUF_STANDARD);

4
src/backend/access/transam/clog.c
View File

@ -1074,7 +1074,7 @@ static void
WriteZeroPageXlogRec(int64 pageno) WriteZeroPageXlogRec(int64 pageno)
{ {
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&pageno), sizeof(pageno)); XLogRegisterData(&pageno, sizeof(pageno));
(void) XLogInsert(RM_CLOG_ID, CLOG_ZEROPAGE); (void) XLogInsert(RM_CLOG_ID, CLOG_ZEROPAGE);
} }
@ -1095,7 +1095,7 @@ WriteTruncateXlogRec(int64 pageno, TransactionId oldestXact, Oid oldestXactDb)
xlrec.oldestXactDb = oldestXactDb; xlrec.oldestXactDb = oldestXactDb;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), sizeof(xl_clog_truncate)); XLogRegisterData(&xlrec, sizeof(xl_clog_truncate));
recptr = XLogInsert(RM_CLOG_ID, CLOG_TRUNCATE); recptr = XLogInsert(RM_CLOG_ID, CLOG_TRUNCATE);
XLogFlush(recptr); XLogFlush(recptr);
} }

4
src/backend/access/transam/commit_ts.c
View File

@ -989,7 +989,7 @@ static void
WriteZeroPageXlogRec(int64 pageno) WriteZeroPageXlogRec(int64 pageno)
{ {
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&pageno), sizeof(pageno)); XLogRegisterData(&pageno, sizeof(pageno));
(void) XLogInsert(RM_COMMIT_TS_ID, COMMIT_TS_ZEROPAGE); (void) XLogInsert(RM_COMMIT_TS_ID, COMMIT_TS_ZEROPAGE);
} }
@ -1005,7 +1005,7 @@ WriteTruncateXlogRec(int64 pageno, TransactionId oldestXid)
xlrec.oldestXid = oldestXid; xlrec.oldestXid = oldestXid;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), SizeOfCommitTsTruncate); XLogRegisterData(&xlrec, SizeOfCommitTsTruncate);
(void) XLogInsert(RM_COMMIT_TS_ID, COMMIT_TS_TRUNCATE); (void) XLogInsert(RM_COMMIT_TS_ID, COMMIT_TS_TRUNCATE);
} }

8
src/backend/access/transam/multixact.c
View File

@ -886,8 +886,8 @@ MultiXactIdCreateFromMembers(int nmembers, MultiXactMember *members)
* Not clear that it's worth the trouble though. * Not clear that it's worth the trouble though.
*/ */
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), SizeOfMultiXactCreate); XLogRegisterData(&xlrec, SizeOfMultiXactCreate);
XLogRegisterData((char *) members, nmembers * sizeof(MultiXactMember)); XLogRegisterData(members, nmembers * sizeof(MultiXactMember));
(void) XLogInsert(RM_MULTIXACT_ID, XLOG_MULTIXACT_CREATE_ID); (void) XLogInsert(RM_MULTIXACT_ID, XLOG_MULTIXACT_CREATE_ID);
@ -3355,7 +3355,7 @@ static void
WriteMZeroPageXlogRec(int64 pageno, uint8 info) WriteMZeroPageXlogRec(int64 pageno, uint8 info)
{ {
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&pageno), sizeof(pageno)); XLogRegisterData(&pageno, sizeof(pageno));
(void) XLogInsert(RM_MULTIXACT_ID, info); (void) XLogInsert(RM_MULTIXACT_ID, info);
} }
@ -3382,7 +3382,7 @@ WriteMTruncateXlogRec(Oid oldestMultiDB,
xlrec.endTruncMemb = endTruncMemb; xlrec.endTruncMemb = endTruncMemb;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), SizeOfMultiXactTruncate); XLogRegisterData(&xlrec, SizeOfMultiXactTruncate);
recptr = XLogInsert(RM_MULTIXACT_ID, XLOG_MULTIXACT_TRUNCATE_ID); recptr = XLogInsert(RM_MULTIXACT_ID, XLOG_MULTIXACT_TRUNCATE_ID);
XLogFlush(recptr); XLogFlush(recptr);
} }

52
src/backend/access/transam/xact.c
View File

@ -770,8 +770,8 @@ AssignTransactionId(TransactionState s)
xlrec.nsubxacts = nUnreportedXids; xlrec.nsubxacts = nUnreportedXids;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, MinSizeOfXactAssignment); XLogRegisterData(&xlrec, MinSizeOfXactAssignment);
XLogRegisterData((char *) unreportedXids, XLogRegisterData(unreportedXids,
nUnreportedXids * sizeof(TransactionId)); nUnreportedXids * sizeof(TransactionId));
(void) XLogInsert(RM_XACT_ID, XLOG_XACT_ASSIGNMENT); (void) XLogInsert(RM_XACT_ID, XLOG_XACT_ASSIGNMENT);
@ -5909,54 +5909,54 @@ XactLogCommitRecord(TimestampTz commit_time,
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), sizeof(xl_xact_commit)); XLogRegisterData(&xlrec, sizeof(xl_xact_commit));
if (xl_xinfo.xinfo != 0) if (xl_xinfo.xinfo != 0)
XLogRegisterData((char *) (&xl_xinfo.xinfo), sizeof(xl_xinfo.xinfo)); XLogRegisterData(&xl_xinfo.xinfo, sizeof(xl_xinfo.xinfo));
if (xl_xinfo.xinfo & XACT_XINFO_HAS_DBINFO) if (xl_xinfo.xinfo & XACT_XINFO_HAS_DBINFO)
XLogRegisterData((char *) (&xl_dbinfo), sizeof(xl_dbinfo)); XLogRegisterData(&xl_dbinfo, sizeof(xl_dbinfo));
if (xl_xinfo.xinfo & XACT_XINFO_HAS_SUBXACTS) if (xl_xinfo.xinfo & XACT_XINFO_HAS_SUBXACTS)
{ {
XLogRegisterData((char *) (&xl_subxacts), XLogRegisterData(&xl_subxacts,
MinSizeOfXactSubxacts); MinSizeOfXactSubxacts);
XLogRegisterData((char *) subxacts, XLogRegisterData(subxacts,
nsubxacts * sizeof(TransactionId)); nsubxacts * sizeof(TransactionId));
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_RELFILELOCATORS) if (xl_xinfo.xinfo & XACT_XINFO_HAS_RELFILELOCATORS)
{ {
XLogRegisterData((char *) (&xl_relfilelocators), XLogRegisterData(&xl_relfilelocators,
MinSizeOfXactRelfileLocators); MinSizeOfXactRelfileLocators);
XLogRegisterData((char *) rels, XLogRegisterData(rels,
nrels * sizeof(RelFileLocator)); nrels * sizeof(RelFileLocator));
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_DROPPED_STATS) if (xl_xinfo.xinfo & XACT_XINFO_HAS_DROPPED_STATS)
{ {
XLogRegisterData((char *) (&xl_dropped_stats), XLogRegisterData(&xl_dropped_stats,
MinSizeOfXactStatsItems); MinSizeOfXactStatsItems);
XLogRegisterData((char *) droppedstats, XLogRegisterData(droppedstats,
ndroppedstats * sizeof(xl_xact_stats_item)); ndroppedstats * sizeof(xl_xact_stats_item));
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_INVALS) if (xl_xinfo.xinfo & XACT_XINFO_HAS_INVALS)
{ {
XLogRegisterData((char *) (&xl_invals), MinSizeOfXactInvals); XLogRegisterData(&xl_invals, MinSizeOfXactInvals);
XLogRegisterData((char *) msgs, XLogRegisterData(msgs,
nmsgs * sizeof(SharedInvalidationMessage)); nmsgs * sizeof(SharedInvalidationMessage));
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_TWOPHASE) if (xl_xinfo.xinfo & XACT_XINFO_HAS_TWOPHASE)
{ {
XLogRegisterData((char *) (&xl_twophase), sizeof(xl_xact_twophase)); XLogRegisterData(&xl_twophase, sizeof(xl_xact_twophase));
if (xl_xinfo.xinfo & XACT_XINFO_HAS_GID) if (xl_xinfo.xinfo & XACT_XINFO_HAS_GID)
XLogRegisterData(twophase_gid, strlen(twophase_gid) + 1); XLogRegisterData(twophase_gid, strlen(twophase_gid) + 1);
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_ORIGIN) if (xl_xinfo.xinfo & XACT_XINFO_HAS_ORIGIN)
XLogRegisterData((char *) (&xl_origin), sizeof(xl_xact_origin)); XLogRegisterData(&xl_origin, sizeof(xl_xact_origin));
/* we allow filtering by xacts */ /* we allow filtering by xacts */
XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN); XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN);
@ -6062,47 +6062,47 @@ XactLogAbortRecord(TimestampTz abort_time,
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), MinSizeOfXactAbort); XLogRegisterData(&xlrec, MinSizeOfXactAbort);
if (xl_xinfo.xinfo != 0) if (xl_xinfo.xinfo != 0)
XLogRegisterData((char *) (&xl_xinfo), sizeof(xl_xinfo)); XLogRegisterData(&xl_xinfo, sizeof(xl_xinfo));
if (xl_xinfo.xinfo & XACT_XINFO_HAS_DBINFO) if (xl_xinfo.xinfo & XACT_XINFO_HAS_DBINFO)
XLogRegisterData((char *) (&xl_dbinfo), sizeof(xl_dbinfo)); XLogRegisterData(&xl_dbinfo, sizeof(xl_dbinfo));
if (xl_xinfo.xinfo & XACT_XINFO_HAS_SUBXACTS) if (xl_xinfo.xinfo & XACT_XINFO_HAS_SUBXACTS)
{ {
XLogRegisterData((char *) (&xl_subxacts), XLogRegisterData(&xl_subxacts,
MinSizeOfXactSubxacts); MinSizeOfXactSubxacts);
XLogRegisterData((char *) subxacts, XLogRegisterData(subxacts,
nsubxacts * sizeof(TransactionId)); nsubxacts * sizeof(TransactionId));
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_RELFILELOCATORS) if (xl_xinfo.xinfo & XACT_XINFO_HAS_RELFILELOCATORS)
{ {
XLogRegisterData((char *) (&xl_relfilelocators), XLogRegisterData(&xl_relfilelocators,
MinSizeOfXactRelfileLocators); MinSizeOfXactRelfileLocators);
XLogRegisterData((char *) rels, XLogRegisterData(rels,
nrels * sizeof(RelFileLocator)); nrels * sizeof(RelFileLocator));
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_DROPPED_STATS) if (xl_xinfo.xinfo & XACT_XINFO_HAS_DROPPED_STATS)
{ {
XLogRegisterData((char *) (&xl_dropped_stats), XLogRegisterData(&xl_dropped_stats,
MinSizeOfXactStatsItems); MinSizeOfXactStatsItems);
XLogRegisterData((char *) droppedstats, XLogRegisterData(droppedstats,
ndroppedstats * sizeof(xl_xact_stats_item)); ndroppedstats * sizeof(xl_xact_stats_item));
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_TWOPHASE) if (xl_xinfo.xinfo & XACT_XINFO_HAS_TWOPHASE)
{ {
XLogRegisterData((char *) (&xl_twophase), sizeof(xl_xact_twophase)); XLogRegisterData(&xl_twophase, sizeof(xl_xact_twophase));
if (xl_xinfo.xinfo & XACT_XINFO_HAS_GID) if (xl_xinfo.xinfo & XACT_XINFO_HAS_GID)
XLogRegisterData(twophase_gid, strlen(twophase_gid) + 1); XLogRegisterData(twophase_gid, strlen(twophase_gid) + 1);
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_ORIGIN) if (xl_xinfo.xinfo & XACT_XINFO_HAS_ORIGIN)
XLogRegisterData((char *) (&xl_origin), sizeof(xl_xact_origin)); XLogRegisterData(&xl_origin, sizeof(xl_xact_origin));
/* Include the replication origin */ /* Include the replication origin */
XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN); XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN);

18
src/backend/access/transam/xlog.c
View File

@ -7078,7 +7078,7 @@ CreateCheckPoint(int flags)
{ {
/* Include WAL level in record for WAL summarizer's benefit. */ /* Include WAL level in record for WAL summarizer's benefit. */
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &wal_level, sizeof(wal_level)); XLogRegisterData(&wal_level, sizeof(wal_level));
(void) XLogInsert(RM_XLOG_ID, XLOG_CHECKPOINT_REDO); (void) XLogInsert(RM_XLOG_ID, XLOG_CHECKPOINT_REDO);
/* /*
@ -7231,7 +7231,7 @@ CreateCheckPoint(int flags)
* Now insert the checkpoint record into XLOG. * Now insert the checkpoint record into XLOG.
*/ */
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&checkPoint), sizeof(checkPoint)); XLogRegisterData(&checkPoint, sizeof(checkPoint));
recptr = XLogInsert(RM_XLOG_ID, recptr = XLogInsert(RM_XLOG_ID,
shutdown ? XLOG_CHECKPOINT_SHUTDOWN : shutdown ? XLOG_CHECKPOINT_SHUTDOWN :
XLOG_CHECKPOINT_ONLINE); XLOG_CHECKPOINT_ONLINE);
@ -7413,7 +7413,7 @@ CreateEndOfRecoveryRecord(void)
START_CRIT_SECTION(); START_CRIT_SECTION();
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xl_end_of_recovery)); XLogRegisterData(&xlrec, sizeof(xl_end_of_recovery));
recptr = XLogInsert(RM_XLOG_ID, XLOG_END_OF_RECOVERY); recptr = XLogInsert(RM_XLOG_ID, XLOG_END_OF_RECOVERY);
XLogFlush(recptr); XLogFlush(recptr);
@ -7506,7 +7506,7 @@ CreateOverwriteContrecordRecord(XLogRecPtr aborted_lsn, XLogRecPtr pagePtr,
XLogBeginInsert(); XLogBeginInsert();
xlrec.overwritten_lsn = aborted_lsn; xlrec.overwritten_lsn = aborted_lsn;
xlrec.overwrite_time = GetCurrentTimestamp(); xlrec.overwrite_time = GetCurrentTimestamp();
XLogRegisterData((char *) &xlrec, sizeof(xl_overwrite_contrecord)); XLogRegisterData(&xlrec, sizeof(xl_overwrite_contrecord));
recptr = XLogInsert(RM_XLOG_ID, XLOG_OVERWRITE_CONTRECORD); recptr = XLogInsert(RM_XLOG_ID, XLOG_OVERWRITE_CONTRECORD);
/* check that the record was inserted to the right place */ /* check that the record was inserted to the right place */
@ -8044,7 +8044,7 @@ void
XLogPutNextOid(Oid nextOid) XLogPutNextOid(Oid nextOid)
{ {
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&nextOid), sizeof(Oid)); XLogRegisterData(&nextOid, sizeof(Oid));
(void) XLogInsert(RM_XLOG_ID, XLOG_NEXTOID); (void) XLogInsert(RM_XLOG_ID, XLOG_NEXTOID);
/* /*
@ -8105,7 +8105,7 @@ XLogRestorePoint(const char *rpName)
strlcpy(xlrec.rp_name, rpName, MAXFNAMELEN); strlcpy(xlrec.rp_name, rpName, MAXFNAMELEN);
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xl_restore_point)); XLogRegisterData(&xlrec, sizeof(xl_restore_point));
RecPtr = XLogInsert(RM_XLOG_ID, XLOG_RESTORE_POINT); RecPtr = XLogInsert(RM_XLOG_ID, XLOG_RESTORE_POINT);
@ -8154,7 +8154,7 @@ XLogReportParameters(void)
xlrec.track_commit_timestamp = track_commit_timestamp; xlrec.track_commit_timestamp = track_commit_timestamp;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
recptr = XLogInsert(RM_XLOG_ID, XLOG_PARAMETER_CHANGE); recptr = XLogInsert(RM_XLOG_ID, XLOG_PARAMETER_CHANGE);
XLogFlush(recptr); XLogFlush(recptr);
@ -8229,7 +8229,7 @@ UpdateFullPageWrites(void)
if (XLogStandbyInfoActive() && !recoveryInProgress) if (XLogStandbyInfoActive() && !recoveryInProgress)
{ {
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&fullPageWrites), sizeof(bool)); XLogRegisterData(&fullPageWrites, sizeof(bool));
XLogInsert(RM_XLOG_ID, XLOG_FPW_CHANGE); XLogInsert(RM_XLOG_ID, XLOG_FPW_CHANGE);
} }
@ -9272,7 +9272,7 @@ do_pg_backup_stop(BackupState *state, bool waitforarchive)
* Write the backup-end xlog record * Write the backup-end xlog record
*/ */
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&state->startpoint), XLogRegisterData(&state->startpoint,
sizeof(state->startpoint)); sizeof(state->startpoint));
state->stoppoint = XLogInsert(RM_XLOG_ID, XLOG_BACKUP_END); state->stoppoint = XLogInsert(RM_XLOG_ID, XLOG_BACKUP_END);

4
src/backend/catalog/storage.c
View File

@ -194,7 +194,7 @@ log_smgrcreate(const RelFileLocator *rlocator, ForkNumber forkNum)
xlrec.forkNum = forkNum; xlrec.forkNum = forkNum;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogInsert(RM_SMGR_ID, XLOG_SMGR_CREATE | XLR_SPECIAL_REL_UPDATE); XLogInsert(RM_SMGR_ID, XLOG_SMGR_CREATE | XLR_SPECIAL_REL_UPDATE);
} }
@ -397,7 +397,7 @@ RelationTruncate(Relation rel, BlockNumber nblocks)
xlrec.flags = SMGR_TRUNCATE_ALL; xlrec.flags = SMGR_TRUNCATE_ALL;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
lsn = XLogInsert(RM_SMGR_ID, lsn = XLogInsert(RM_SMGR_ID,
XLOG_SMGR_TRUNCATE | XLR_SPECIAL_REL_UPDATE); XLOG_SMGR_TRUNCATE | XLR_SPECIAL_REL_UPDATE);

14
src/backend/commands/dbcommands.c
View File

@ -529,7 +529,7 @@ CreateDirAndVersionFile(char *dbpath, Oid dbid, Oid tsid, bool isRedo)
xlrec.tablespace_id = tsid; xlrec.tablespace_id = tsid;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), XLogRegisterData(&xlrec,
sizeof(xl_dbase_create_wal_log_rec)); sizeof(xl_dbase_create_wal_log_rec));
(void) XLogInsert(RM_DBASE_ID, XLOG_DBASE_CREATE_WAL_LOG); (void) XLogInsert(RM_DBASE_ID, XLOG_DBASE_CREATE_WAL_LOG);
@ -625,7 +625,7 @@ CreateDatabaseUsingFileCopy(Oid src_dboid, Oid dst_dboid, Oid src_tsid,
xlrec.src_tablespace_id = srctablespace; xlrec.src_tablespace_id = srctablespace;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, XLogRegisterData(&xlrec,
sizeof(xl_dbase_create_file_copy_rec)); sizeof(xl_dbase_create_file_copy_rec));
(void) XLogInsert(RM_DBASE_ID, (void) XLogInsert(RM_DBASE_ID,
@ -2183,7 +2183,7 @@ movedb(const char *dbname, const char *tblspcname)
xlrec.src_tablespace_id = src_tblspcoid; xlrec.src_tablespace_id = src_tblspcoid;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, XLogRegisterData(&xlrec,
sizeof(xl_dbase_create_file_copy_rec)); sizeof(xl_dbase_create_file_copy_rec));
(void) XLogInsert(RM_DBASE_ID, (void) XLogInsert(RM_DBASE_ID,
@ -2279,8 +2279,8 @@ movedb(const char *dbname, const char *tblspcname)
xlrec.ntablespaces = 1; xlrec.ntablespaces = 1;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xl_dbase_drop_rec)); XLogRegisterData(&xlrec, sizeof(xl_dbase_drop_rec));
XLogRegisterData((char *) &src_tblspcoid, sizeof(Oid)); XLogRegisterData(&src_tblspcoid, sizeof(Oid));
(void) XLogInsert(RM_DBASE_ID, (void) XLogInsert(RM_DBASE_ID,
XLOG_DBASE_DROP | XLR_SPECIAL_REL_UPDATE); XLOG_DBASE_DROP | XLR_SPECIAL_REL_UPDATE);
@ -3037,8 +3037,8 @@ remove_dbtablespaces(Oid db_id)
xlrec.ntablespaces = ntblspc; xlrec.ntablespaces = ntblspc;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, MinSizeOfDbaseDropRec); XLogRegisterData(&xlrec, MinSizeOfDbaseDropRec);
XLogRegisterData((char *) tablespace_ids, ntblspc * sizeof(Oid)); XLogRegisterData(tablespace_ids, ntblspc * sizeof(Oid));
(void) XLogInsert(RM_DBASE_ID, (void) XLogInsert(RM_DBASE_ID,
XLOG_DBASE_DROP | XLR_SPECIAL_REL_UPDATE); XLOG_DBASE_DROP | XLR_SPECIAL_REL_UPDATE);

12
src/backend/commands/sequence.c
View File

@ -415,8 +415,8 @@ fill_seq_fork_with_data(Relation rel, HeapTuple tuple, ForkNumber forkNum)
xlrec.locator = rel->rd_locator; xlrec.locator = rel->rd_locator;
XLogRegisterData((char *) &xlrec, sizeof(xl_seq_rec)); XLogRegisterData(&xlrec, sizeof(xl_seq_rec));
XLogRegisterData((char *) tuple->t_data, tuple->t_len); XLogRegisterData(tuple->t_data, tuple->t_len);
recptr = XLogInsert(RM_SEQ_ID, XLOG_SEQ_LOG); recptr = XLogInsert(RM_SEQ_ID, XLOG_SEQ_LOG);
@ -840,8 +840,8 @@ nextval_internal(Oid relid, bool check_permissions)
xlrec.locator = seqrel->rd_locator; xlrec.locator = seqrel->rd_locator;
XLogRegisterData((char *) &xlrec, sizeof(xl_seq_rec)); XLogRegisterData(&xlrec, sizeof(xl_seq_rec));
XLogRegisterData((char *) seqdatatuple.t_data, seqdatatuple.t_len); XLogRegisterData(seqdatatuple.t_data, seqdatatuple.t_len);
recptr = XLogInsert(RM_SEQ_ID, XLOG_SEQ_LOG); recptr = XLogInsert(RM_SEQ_ID, XLOG_SEQ_LOG);
@ -1026,8 +1026,8 @@ do_setval(Oid relid, int64 next, bool iscalled)
XLogRegisterBuffer(0, buf, REGBUF_WILL_INIT); XLogRegisterBuffer(0, buf, REGBUF_WILL_INIT);
xlrec.locator = seqrel->rd_locator; xlrec.locator = seqrel->rd_locator;
XLogRegisterData((char *) &xlrec, sizeof(xl_seq_rec)); XLogRegisterData(&xlrec, sizeof(xl_seq_rec));
XLogRegisterData((char *) seqdatatuple.t_data, seqdatatuple.t_len); XLogRegisterData(seqdatatuple.t_data, seqdatatuple.t_len);
recptr = XLogInsert(RM_SEQ_ID, XLOG_SEQ_LOG); recptr = XLogInsert(RM_SEQ_ID, XLOG_SEQ_LOG);

4
src/backend/commands/tablecmds.c
View File

@ -2283,8 +2283,8 @@ ExecuteTruncateGuts(List *explicit_rels,
xlrec.flags |= XLH_TRUNCATE_RESTART_SEQS; xlrec.flags |= XLH_TRUNCATE_RESTART_SEQS;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfHeapTruncate); XLogRegisterData(&xlrec, SizeOfHeapTruncate);
XLogRegisterData((char *) logrelids, list_length(relids_logged) * sizeof(Oid)); XLogRegisterData(logrelids, list_length(relids_logged) * sizeof(Oid));
XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN); XLogSetRecordFlags(XLOG_INCLUDE_ORIGIN);

6
src/backend/commands/tablespace.c
View File

@ -363,9 +363,9 @@ CreateTableSpace(CreateTableSpaceStmt *stmt)
xlrec.ts_id = tablespaceoid; xlrec.ts_id = tablespaceoid;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, XLogRegisterData(&xlrec,
offsetof(xl_tblspc_create_rec, ts_path)); offsetof(xl_tblspc_create_rec, ts_path));
XLogRegisterData((char *) location, strlen(location) + 1); XLogRegisterData(location, strlen(location) + 1);
(void) XLogInsert(RM_TBLSPC_ID, XLOG_TBLSPC_CREATE); (void) XLogInsert(RM_TBLSPC_ID, XLOG_TBLSPC_CREATE);
} }
@ -533,7 +533,7 @@ DropTableSpace(DropTableSpaceStmt *stmt)
xlrec.ts_id = tablespaceoid; xlrec.ts_id = tablespaceoid;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, sizeof(xl_tblspc_drop_rec)); XLogRegisterData(&xlrec, sizeof(xl_tblspc_drop_rec));
(void) XLogInsert(RM_TBLSPC_ID, XLOG_TBLSPC_DROP); (void) XLogInsert(RM_TBLSPC_ID, XLOG_TBLSPC_DROP);
} }

2
src/backend/replication/logical/message.c
View File

@ -62,7 +62,7 @@ LogLogicalMessage(const char *prefix, const char *message, size_t size,
xlrec.message_size = size; xlrec.message_size = size;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfLogicalMessage); XLogRegisterData(&xlrec, SizeOfLogicalMessage);
XLogRegisterData(prefix, xlrec.prefix_size); XLogRegisterData(prefix, xlrec.prefix_size);
XLogRegisterData(message, size); XLogRegisterData(message, size);

4
src/backend/replication/logical/origin.c
View File

@ -391,7 +391,7 @@ restart:
xlrec.node_id = roident; xlrec.node_id = roident;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogInsert(RM_REPLORIGIN_ID, XLOG_REPLORIGIN_DROP); XLogInsert(RM_REPLORIGIN_ID, XLOG_REPLORIGIN_DROP);
} }
@ -986,7 +986,7 @@ replorigin_advance(RepOriginId node,
xlrec.force = go_backward; xlrec.force = go_backward;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), sizeof(xlrec)); XLogRegisterData(&xlrec, sizeof(xlrec));
XLogInsert(RM_REPLORIGIN_ID, XLOG_REPLORIGIN_SET); XLogInsert(RM_REPLORIGIN_ID, XLOG_REPLORIGIN_SET);
} }

12
src/backend/storage/ipc/standby.c
View File

@ -1353,11 +1353,11 @@ LogCurrentRunningXacts(RunningTransactions CurrRunningXacts)
/* Header */ /* Header */
XLogBeginInsert(); XLogBeginInsert();
XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT); XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT);
XLogRegisterData((char *) (&xlrec), MinSizeOfXactRunningXacts); XLogRegisterData(&xlrec, MinSizeOfXactRunningXacts);
/* array of TransactionIds */ /* array of TransactionIds */
if (xlrec.xcnt > 0) if (xlrec.xcnt > 0)
XLogRegisterData((char *) CurrRunningXacts->xids, XLogRegisterData(CurrRunningXacts->xids,
(xlrec.xcnt + xlrec.subxcnt) * sizeof(TransactionId)); (xlrec.xcnt + xlrec.subxcnt) * sizeof(TransactionId));
recptr = XLogInsert(RM_STANDBY_ID, XLOG_RUNNING_XACTS); recptr = XLogInsert(RM_STANDBY_ID, XLOG_RUNNING_XACTS);
@ -1405,8 +1405,8 @@ LogAccessExclusiveLocks(int nlocks, xl_standby_lock *locks)
xlrec.nlocks = nlocks; xlrec.nlocks = nlocks;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, offsetof(xl_standby_locks, locks)); XLogRegisterData(&xlrec, offsetof(xl_standby_locks, locks));
XLogRegisterData((char *) locks, nlocks * sizeof(xl_standby_lock)); XLogRegisterData(locks, nlocks * sizeof(xl_standby_lock));
XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT); XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT);
(void) XLogInsert(RM_STANDBY_ID, XLOG_STANDBY_LOCK); (void) XLogInsert(RM_STANDBY_ID, XLOG_STANDBY_LOCK);
@ -1469,8 +1469,8 @@ LogStandbyInvalidations(int nmsgs, SharedInvalidationMessage *msgs,
/* perform insertion */ /* perform insertion */
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), MinSizeOfInvalidations); XLogRegisterData(&xlrec, MinSizeOfInvalidations);
XLogRegisterData((char *) msgs, XLogRegisterData(msgs,
nmsgs * sizeof(SharedInvalidationMessage)); nmsgs * sizeof(SharedInvalidationMessage));
XLogInsert(RM_STANDBY_ID, XLOG_INVALIDATIONS); XLogInsert(RM_STANDBY_ID, XLOG_INVALIDATIONS);
} }

6
src/backend/utils/cache/inval.c vendored
View File

@ -1813,12 +1813,12 @@ LogLogicalInvalidations(void)
/* perform insertion */ /* perform insertion */
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), MinSizeOfXactInvals); XLogRegisterData(&xlrec, MinSizeOfXactInvals);
ProcessMessageSubGroupMulti(group, CatCacheMsgs, ProcessMessageSubGroupMulti(group, CatCacheMsgs,
XLogRegisterData((char *) msgs, XLogRegisterData(msgs,
n * sizeof(SharedInvalidationMessage))); n * sizeof(SharedInvalidationMessage)));
ProcessMessageSubGroupMulti(group, RelCacheMsgs, ProcessMessageSubGroupMulti(group, RelCacheMsgs,
XLogRegisterData((char *) msgs, XLogRegisterData(msgs,
n * sizeof(SharedInvalidationMessage))); n * sizeof(SharedInvalidationMessage)));
XLogInsert(RM_XACT_ID, XLOG_XACT_INVALIDATIONS); XLogInsert(RM_XACT_ID, XLOG_XACT_INVALIDATIONS);
} }

4
src/backend/utils/cache/relmapper.c vendored
View File

@ -969,8 +969,8 @@ write_relmap_file(RelMapFile *newmap, bool write_wal, bool send_sinval,
xlrec.nbytes = sizeof(RelMapFile); xlrec.nbytes = sizeof(RelMapFile);
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) (&xlrec), MinSizeOfRelmapUpdate); XLogRegisterData(&xlrec, MinSizeOfRelmapUpdate);
XLogRegisterData((char *) newmap, sizeof(RelMapFile)); XLogRegisterData(newmap, sizeof(RelMapFile));
lsn = XLogInsert(RM_RELMAP_ID, XLOG_RELMAP_UPDATE); lsn = XLogInsert(RM_RELMAP_ID, XLOG_RELMAP_UPDATE);

4
src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c
View File

@ -128,8 +128,8 @@ test_custom_rmgrs_insert_wal_record(PG_FUNCTION_ARGS)
xlrec.message_size = len; xlrec.message_size = len;
XLogBeginInsert(); XLogBeginInsert();
XLogRegisterData((char *) &xlrec, SizeOfTestCustomRmgrsMessage); XLogRegisterData(&xlrec, SizeOfTestCustomRmgrsMessage);
XLogRegisterData((char *) payload, len); XLogRegisterData(payload, len);
/* Let's mark this record as unimportant, just in case. */ /* Let's mark this record as unimportant, just in case. */
XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT); XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT);