mirror of
https://github.com/postgres/postgres.git
synced 2025-07-15 19:21:59 +03:00
Add makefile rules to check for backtracking in backend and psql lexers.
Per discussion, we should enforce the policy of "no backtracking" in these performance-sensitive scanners.
This commit is contained in:
@ -17,7 +17,7 @@ OBJS= analyze.o gram.o keywords.o kwlookup.o parser.o \
|
||||
parse_expr.o parse_func.o parse_node.o parse_oper.o parse_param.o \
|
||||
parse_relation.o parse_target.o parse_type.o parse_utilcmd.o scansup.o
|
||||
|
||||
FLEXFLAGS = -CF
|
||||
FLEXFLAGS = -CF -b -p -p
|
||||
|
||||
include $(top_srcdir)/src/backend/common.mk
|
||||
|
||||
@ -51,6 +51,7 @@ endif
|
||||
scan.c: scan.l
|
||||
ifdef FLEX
|
||||
$(FLEX) $(FLEXFLAGS) -o'$@' $<
|
||||
@if [ `wc -l <lex.backup` -eq 1 ]; then rm lex.backup; else echo "Scanner requires backup, see lex.backup."; exit 1; fi
|
||||
else
|
||||
@$(missing) flex $< $@
|
||||
endif
|
||||
@ -62,3 +63,5 @@ gram.o keywords.o parser.o: gram.h
|
||||
|
||||
# gram.c, gram.h, and scan.c are in the distribution tarball, so they
|
||||
# are not cleaned here.
|
||||
clean distclean maintainer-clean:
|
||||
rm -f lex.backup
|
||||
|
@ -17,7 +17,8 @@
|
||||
* for handling float numbers and continued string literals. If you change
|
||||
* the lexical rules, verify that you haven't broken the no-backtrack
|
||||
* property by running flex with the "-b" option and checking that the
|
||||
* resulting "lex.backup" file says that no backing up is needed.
|
||||
* resulting "lex.backup" file says that no backing up is needed. (As of
|
||||
* Postgres 9.2, this check is made automatically by the Makefile.)
|
||||
*
|
||||
*
|
||||
* Portions Copyright (c) 1996-2011, PostgreSQL Global Development Group
|
||||
|
Reference in New Issue
Block a user