database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-09 06:21:09 +03:00
Code Activity

Generate pgstat_count_slru*() functions for slru using macros

Browse Source 
This change replaces seven functions definitions by macros, reducing a
bit some repetitive patterns in the code.  An interesting side effect is
that this removes an inconsistency in the naming of SLRU increment
functions with the field names.

This change is similar to 850f4b4c8c, 8018ffbf58 or 83a1a1b566.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/aLHA//gr4dTpDHHC@ip-10-97-1-34.eu-west-3.compute.internal
This commit is contained in:
Michael Paquier
2025-09-02 16:22:03 +09:00
parent a850be2fe6
commit eccba079c2
3 changed files with 31 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/access/transam/slru.c
View File

@@ -408,7 +408,7 @@ SimpleLruZeroPage(SlruCtl ctl, int64 pageno)
pg_atomic_write_u64(&shared->latest_page_number, pageno);
/* update the stats counter of zeroed pages */
pgstat_count_slru_page_zeroed(shared->slru_stats_idx);
pgstat_count_slru_blocks_zeroed(shared->slru_stats_idx);
return slotno;
}
@@ -560,7 +560,7 @@ SimpleLruReadPage(SlruCtl ctl, int64 pageno, bool write_ok,
SlruRecentlyUsed(shared, slotno);
/* update the stats counter of pages found in the SLRU */
pgstat_count_slru_page_hit(shared->slru_stats_idx);
pgstat_count_slru_blocks_hit(shared->slru_stats_idx);
return slotno;
}
@@ -605,7 +605,7 @@ SimpleLruReadPage(SlruCtl ctl, int64 pageno, bool write_ok,
SlruRecentlyUsed(shared, slotno);
/* update the stats counter of pages not found in SLRU */
pgstat_count_slru_page_read(shared->slru_stats_idx);
pgstat_count_slru_blocks_read(shared->slru_stats_idx);
return slotno;
}
@@ -648,7 +648,7 @@ SimpleLruReadPage_ReadOnly(SlruCtl ctl, int64 pageno, TransactionId xid)
SlruRecentlyUsed(shared, slotno);
/* update the stats counter of pages found in the SLRU */
pgstat_count_slru_page_hit(shared->slru_stats_idx);
pgstat_count_slru_blocks_hit(shared->slru_stats_idx);
return slotno;
}
@@ -778,7 +778,7 @@ SimpleLruDoesPhysicalPageExist(SlruCtl ctl, int64 pageno)
off_t endpos;
/* update the stats counter of checked pages */
pgstat_count_slru_page_exists(ctl->shared->slru_stats_idx);
pgstat_count_slru_blocks_exists(ctl->shared->slru_stats_idx);
SlruFileName(ctl, path, segno);
@@ -907,7 +907,7 @@ SlruPhysicalWritePage(SlruCtl ctl, int64 pageno, int slotno, SlruWriteAll fdata)
int fd = -1;
/* update the stats counter of written pages */
pgstat_count_slru_page_written(shared->slru_stats_idx);
pgstat_count_slru_blocks_written(shared->slru_stats_idx);
/*
* Honor the write-WAL-before-data rule, if appropriate, so that we do not