database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-05 23:56:58 +03:00
Code

Remove incorrect assertion in clog.c

Browse Source 
We must advance the oldest XID that can be safely looked up in clog
*before* truncating CLOG, and the oldest XID that can't be reused
*after* truncating CLOG.  This assertion, and the accompanying
comment, are confused; remove them.

Reported by Neha Sharma.

Discussion: http://postgr.es/m/CANiYTQumC3T=UMBMd1Hor=5XWZYuCEQBioL3ug0YtNQCMMT5wQ@mail.gmail.com
This commit is contained in:
Robert Haas 2017-08-10 11:20:57 -04:00
parent 749c7c4170
commit ec99dd5aee
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/access/transam/clog.c
View File

@ -678,10 +678,6 @@ TruncateCLOG(TransactionId oldestXact, Oid oldestxid_datoid)
*/ */
AdvanceOldestClogXid(oldestXact); AdvanceOldestClogXid(oldestXact);
/* vac_truncate_clog already advanced oldestXid */
Assert(TransactionIdPrecedesOrEquals(oldestXact,
ShmemVariableCache->oldestXid));
/* /*
* Write XLOG record and flush XLOG to disk. We record the oldest xid * Write XLOG record and flush XLOG to disk. We record the oldest xid
* we're keeping information about here so we can ensure that it's always * we're keeping information about here so we can ensure that it's always