database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-24 10:47:04 +03:00
Code

Fix alignment of GIN in-line posting lists stored in entry tuples.

Browse Source 
The Sparc machines in the buildfarm are crashing because of misaligned
access to posting lists stored in entry tuples.

I accidentally removed a critical SHORTALIGN() from ginFormTuple, as part
of the packed posting lists patch. Perhaps I thought it was unnecessary,
because the index_form_tuple() call above the SHORTALIGN already aligned
the size, missing the fact that the null-category byte makes it misaligned
again (I think the SHORTALIGN is indeed unnecessary if there's no null-
category byte, but let's just play it safe...)
This commit is contained in:
Heikki Linnakangas 2014-01-23 22:58:12 +02:00
parent 0fdb2f7d7c
commit ec8f692c3c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/gin/ginentrypage.c
View File

@ -87,6 +87,8 @@ GinFormTuple(GinState *ginstate,
newsize = Max(newsize, minsize); newsize = Max(newsize, minsize);
} }
newsize = SHORTALIGN(newsize);
GinSetPostingOffset(itup, newsize); GinSetPostingOffset(itup, newsize);
GinSetNPosting(itup, nipd); GinSetNPosting(itup, nipd);