database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Fix one overflow and one signedness error, caused by the patch to calculate

Browse Source 
OLDSERXID_MAX_PAGE based on BLCKSZ. MSVC compiler warned about these.
This commit is contained in:
Heikki Linnakangas
2011-07-08 17:28:27 +03:00
parent ebea4c531c
commit ec194651b8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/storage/lmgr/predicate.c
View File

@@ -311,7 +311,7 @@ static SlruCtlData OldSerXidSlruCtlData;
* transactions and the maximum that SLRU supports.
*/
#define OLDSERXID_MAX_PAGE Min(SLRU_PAGES_PER_SEGMENT * 0x10000 - 1, \
(MaxTransactionId + 1) / OLDSERXID_ENTRIESPERPAGE - 1)
(MaxTransactionId) / OLDSERXID_ENTRIESPERPAGE)
#define OldSerXidNextPage(page) (((page) >= OLDSERXID_MAX_PAGE) ? 0 : (page) + 1)
@@ -767,7 +767,7 @@ OldSerXidPagePrecedesLogically(int p, int q)
diff = p - q;
if (diff >= ((OLDSERXID_MAX_PAGE + 1) / 2))
diff -= OLDSERXID_MAX_PAGE + 1;
else if (diff < -((OLDSERXID_MAX_PAGE + 1) / 2))
else if (diff < -((int) (OLDSERXID_MAX_PAGE + 1) / 2))
diff += OLDSERXID_MAX_PAGE + 1;
return diff < 0;
}