From ebbfa2ae34ce85d09fe9ea87b41f9186864c7075 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 8 Nov 2024 07:17:55 +0100 Subject: [PATCH] Message style improvement Backpatch the part of edee0c621de that applies to a90bdd7a44d, which was also backpatched. That way, the message is consistent in all branches. --- src/backend/commands/tablecmds.c | 2 +- src/test/regress/expected/foreign_key.out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 24c0e82c016..143711045ef 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -9765,7 +9765,7 @@ CloneFkReferencing(List **wqueue, Relation parentRel, Relation partRel) if (fk->confrelid == RelationGetRelid(partRel)) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("can't attach table \"%s\" as a partition which is referenced by foreign key \"%s\"", + errmsg("cannot attach table \"%s\" as a partition because it is referenced by foreign key \"%s\"", RelationGetRelationName(partRel), get_constraint_name(fk->conoid)))); diff --git a/src/test/regress/expected/foreign_key.out b/src/test/regress/expected/foreign_key.out index 5eecdf4af2b..501db7718ce 100644 --- a/src/test/regress/expected/foreign_key.out +++ b/src/test/regress/expected/foreign_key.out @@ -1901,7 +1901,7 @@ ALTER TABLE fk_partitioned_fk ATTACH PARTITION fk_partitioned_fk_2 CREATE TABLE fk_partitioned_pk_6 (a int PRIMARY KEY); CREATE TABLE fk_partitioned_fk_6 (a int REFERENCES fk_partitioned_pk_6) PARTITION BY LIST (a); ALTER TABLE fk_partitioned_fk_6 ATTACH PARTITION fk_partitioned_pk_6 FOR VALUES IN (1); -ERROR: can't attach table "fk_partitioned_pk_6" as a partition which is referenced by foreign key "fk_partitioned_fk_6_a_fkey" +ERROR: cannot attach table "fk_partitioned_pk_6" as a partition because it is referenced by foreign key "fk_partitioned_fk_6_a_fkey" DROP TABLE fk_partitioned_pk_6, fk_partitioned_fk_6; -- This case is similar to above, but the referenced relation is one level -- lower in the hierarchy. This one fails in a different way as the above,