database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-26 23:43:30 +03:00
Code Activity

Fix incorrect IndexOptInfo header comment

Browse Source 
The comment incorrectly indicated that indexcollations[] stored
collations for both key columns and INCLUDE columns, but in reality it
only has elements for the key columns.  canreturn[] didn't get a mention,
so add that while we're here.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
Backpatch-through: 14
This commit is contained in:
David Rowley
2025-11-24 17:02:24 +13:00
parent 035a1f5aca
commit ea36c2f6a9
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/include/nodes/pathnodes.h
View File

@@ -796,9 +796,10 @@ typedef struct RelOptInfo
* IndexOptInfo * IndexOptInfo
* Per-index information for planning/optimization * Per-index information for planning/optimization
* *
* indexkeys[], indexcollations[] each have ncolumns entries. * indexkeys[] and canreturn[] each have ncolumns entries.
* opfamily[], and opcintype[] each have nkeycolumns entries. They do *
* not contain any information about included attributes. * indexcollations[], opfamily[], and opcintype[] each have nkeycolumns
* entries. These don't contain any information about INCLUDE columns.
* *
* sortopfamily[], reverse_sort[], and nulls_first[] have * sortopfamily[], reverse_sort[], and nulls_first[] have
* nkeycolumns entries, if the index is ordered; but if it is unordered, * nkeycolumns entries, if the index is ordered; but if it is unordered,