From ea24eadda01088e0fa43d7961244db4ffd9961e9 Mon Sep 17 00:00:00 2001 From: David Rowley Date: Tue, 29 Sep 2026 15:49:08 +1300 Subject: [PATCH] Fix incorrect calcSumX2 in numeric deserialize functions calcSumX2 is used to inform the aggregate transition function whether it should include the square of the transition value in the aggregate state. The deserialize functions for various numeric aggregates that do use calcSumX2 weren't properly setting the property to true. This does not matter in core as we never perform any aggregate transitions after a deserialize operation. This fix is only required for external code which plumbs aggregate paths together in such a way that could result in aggregate transitions being performed after states have been deserialized. Author: Maxime Schoemans Reviewed-by: Andrey Borodin Discussion: https://postgr.es/m/FEBF5C3D-CC53-455F-AA9D-4D377A2E957C@enterprisedb.com Backpatch-through: 14 --- src/backend/utils/adt/numeric.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c index a372237cf65..6a88f579424 100644 --- a/src/backend/utils/adt/numeric.c +++ b/src/backend/utils/adt/numeric.c @@ -5529,7 +5529,7 @@ numeric_deserialize(PG_FUNCTION_ARGS) initReadOnlyStringInfo(&buf, VARDATA_ANY(sstate), VARSIZE_ANY_EXHDR(sstate)); - result = makeNumericAggStateCurrentContext(false); + result = makeNumericAggStateCurrentContext(true); /* N */ result->N = pq_getmsgint64(&buf); @@ -5906,7 +5906,7 @@ numeric_poly_deserialize(PG_FUNCTION_ARGS) initReadOnlyStringInfo(&buf, VARDATA_ANY(sstate), VARSIZE_ANY_EXHDR(sstate)); - result = makePolyNumAggStateCurrentContext(false); + result = makePolyNumAggStateCurrentContext(true); /* N */ result->N = pq_getmsgint64(&buf);