database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-21 12:05:57 +03:00
Code

amcheck: Fix verify_heapam for tuples where xmin or xmax is 0.

Browse Source 
In such cases, get_xid_status() doesn't set its output parameter (the
third argument), so we shouldn't fall through to code which will test
the value of that parameter. There are five existing calls to
get_xid_status(), three of which seem to already handle this case
properly.  This commit tries to fix the other two.

If we're checking xmin and find that it is invalid (i.e. 0) just
report that as corruption, similar to what's already done in the
three cases that seem correct. If we're checking xmax and find
that's invalid, that's fine: it just means that the tuple hasn't
been updated or deleted.

Thanks to Andres Freund and valgrind for finding this problem, and
also to Andres for having a look at the patch.  This bug seems to go
all the way back to where verify_heapam was first introduced, but
wasn't detected until recently, possibly because of the new test cases
added for update chain verification.  Back-patch to v14, where this
code showed up.

Discussion: http://postgr.es/m/CA+TgmoZAYzQZqyUparXy_ks3OEOfLD9-bEXt8N-2tS1qghX9gQ@mail.gmail.com
This commit is contained in:
Robert Haas 2023-03-23 15:29:28 -04:00
parent a04761ac77
commit e88754a196
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/amcheck/verify_heapam.c
View File

@ -1012,7 +1012,9 @@ check_tuple_visibility(HeapCheckContext *ctx, bool *xmin_commit_status_ok,
switch (get_xid_status(xmin, ctx, &xmin_status)) switch (get_xid_status(xmin, ctx, &xmin_status))
{ {
case XID_INVALID: case XID_INVALID:
break; report_corruption(ctx,
pstrdup("xmin is invalid"));
return false;
case XID_BOUNDS_OK: case XID_BOUNDS_OK:
*xmin_commit_status_ok = true; *xmin_commit_status_ok = true;
*xmin_commit_status = xmin_status; *xmin_commit_status = xmin_status;
@ -1350,6 +1352,9 @@ check_tuple_visibility(HeapCheckContext *ctx, bool *xmin_commit_status_ok,
xmax = HeapTupleHeaderGetRawXmax(tuphdr); xmax = HeapTupleHeaderGetRawXmax(tuphdr);
switch (get_xid_status(xmax, ctx, &xmax_status)) switch (get_xid_status(xmax, ctx, &xmax_status))
{ {
case XID_INVALID:
ctx->tuple_could_be_pruned = false;
return true;
case XID_IN_FUTURE: case XID_IN_FUTURE:
report_corruption(ctx, report_corruption(ctx,
psprintf("xmax %u equals or exceeds next valid transaction ID %u:%u", psprintf("xmax %u equals or exceeds next valid transaction ID %u:%u",
@ -1372,7 +1377,6 @@ check_tuple_visibility(HeapCheckContext *ctx, bool *xmin_commit_status_ok,
XidFromFullTransactionId(ctx->oldest_fxid))); XidFromFullTransactionId(ctx->oldest_fxid)));
return false; /* corrupt */ return false; /* corrupt */
case XID_BOUNDS_OK: case XID_BOUNDS_OK:
case XID_INVALID:
break; break;
} }