From e7887fe00db214b141a29f4298c7bb6536292a7e Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Wed, 15 Apr 2020 15:56:52 +0900 Subject: [PATCH] Fix minor memory leak in pg_dump A query used to read default ACL information from the catalogs did not free a set of PQExpBuffer. Oversight in commit e2090d9, so backpatch down to 9.6. Author: Jie Zhang Reviewed-by: Sawada Masahiko Discussion: https://postgr.es/m/05bcbc5857f948efa0b451b85a48ae10@G08CNEXMBPEKD06.g08.fujitsu.local Backpatch-through: 9.6 --- src/bin/pg_dump/pg_dump.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 8b3b1bf91ec..bd14d387403 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -8982,6 +8982,11 @@ getDefaultACLs(Archive *fout, int *numDefaultACLs) racl_subquery->data, initacl_subquery->data, initracl_subquery->data); + + destroyPQExpBuffer(acl_subquery); + destroyPQExpBuffer(racl_subquery); + destroyPQExpBuffer(initacl_subquery); + destroyPQExpBuffer(initracl_subquery); } else {