database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-30 21:42:05 +03:00
Code Activity

Fix memory leak in relcache handling of rules: allocate rule parsetrees

Browse Source 
in per-entry sub-memory-context, where they were supposed to go, rather
than in CacheMemoryContext where the code was putting them.  Must've
suffered a severe brain fade when I wrote this :-(
This commit is contained in:
Tom Lane
2001-01-06 21:53:18 +00:00
parent ca88243952
commit e69b8d4655
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/cache/relcache.c vendored
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.124 2001/01/06 01:48:59 inoue Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.125 2001/01/06 21:53:18 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -881,7 +881,7 @@ RelationBuildRuleLock(Relation relation)
Assert(! isnull); Assert(! isnull);
ruleaction_str = DatumGetCString(DirectFunctionCall1(textout, ruleaction_str = DatumGetCString(DirectFunctionCall1(textout,
ruleaction)); ruleaction));
oldcxt = MemoryContextSwitchTo(CacheMemoryContext); oldcxt = MemoryContextSwitchTo(rulescxt);
rule->actions = (List *) stringToNode(ruleaction_str); rule->actions = (List *) stringToNode(ruleaction_str);
MemoryContextSwitchTo(oldcxt); MemoryContextSwitchTo(oldcxt);
pfree(ruleaction_str); pfree(ruleaction_str);
@ -893,7 +893,7 @@ RelationBuildRuleLock(Relation relation)
Assert(! isnull); Assert(! isnull);
rule_evqual_str = DatumGetCString(DirectFunctionCall1(textout, rule_evqual_str = DatumGetCString(DirectFunctionCall1(textout,
rule_evqual)); rule_evqual));
oldcxt = MemoryContextSwitchTo(CacheMemoryContext); oldcxt = MemoryContextSwitchTo(rulescxt);
rule->qual = (Node *) stringToNode(rule_evqual_str); rule->qual = (Node *) stringToNode(rule_evqual_str);
MemoryContextSwitchTo(oldcxt); MemoryContextSwitchTo(oldcxt);
pfree(rule_evqual_str); pfree(rule_evqual_str);