database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

pgbench: If we fail to send a command to the server, fail.

Browse Source 
This beats the old behavior of busy-waiting hands down.

Oversight in commit 12788ae49e.

Report by Pavan Deolasee. Patch by Fabien Coelho.  Reviewed by
Pavan Deolasee.

Discussion: http://postgr.es/m/CABOikdPhfXTypckMC1Ux6Ko+hKBWwUBA=EXsvamXYSg8M9J94w@mail.gmail.com
This commit is contained in:
Robert Haas
2017-09-29 13:51:14 -04:00
parent 2a14b9609d
commit e55d9643ec
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/bin/pgbench/pgbench.c
View File

@ -2194,12 +2194,8 @@ doCustom(TState *thread, CState *st, StatsData *agg)
{ {
if (!sendCommand(st, command)) if (!sendCommand(st, command))
{ {
/* commandFailed(st, "SQL command send failed");
* Failed. Stay in CSTATE_START_COMMAND state, to st->state = CSTATE_ABORTED;
* retry. ??? What the point or retrying? Should
* rather abort?
*/
return;
} }
else else
st->state = CSTATE_WAIT_RESULT; st->state = CSTATE_WAIT_RESULT;