database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

Fix argument handling in pg_indexam_progress_phasename()

Browse Source 
The function is declared in pg_proc.dat a bigint as its second input
argument, but the function's code used PG_GETARG_INT32().

This is an issue in 32-bit architectures in stable branches (up to v18)
where bigint is still passed by reference, reporting bogus numbers.
Since 2a600a93c7 (v19 and HEAD), this is less of a problem as Datums
became 8-byte wide everywhere.

Oversight in ab0dfc961b.

Author: Markos Fountoulakis <markos@planetscale.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/e791bbb7-af3a-4a91-a5bb-c744e5c3ef54@planetscale.com
Backpatch-through: 14
This commit is contained in:
Michael Paquier
2026-10-22 14:39:15 +09:00
parent fbb9d76aa0
commit e4ac005142
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/utils/adt/amutils.c
View File

@@ -454,7 +454,7 @@ Datum
pg_indexam_progress_phasename(PG_FUNCTION_ARGS) pg_indexam_progress_phasename(PG_FUNCTION_ARGS)
{ {
Oid amoid = PG_GETARG_OID(0); Oid amoid = PG_GETARG_OID(0);
int32 phasenum = PG_GETARG_INT32(1); int64 phasenum = PG_GETARG_INT64(1);
IndexAmRoutine *routine; IndexAmRoutine *routine;
char *name; char *name;