database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Update HINT for pre-existing shared memory block.

Browse Source 
One should almost always terminate an old process, not use a manual
removal tool like ipcrm.  Removal of the ipcclean script eleven years
ago (39627b1ae6) and its non-replacement
corroborate that manual shm removal is now a niche goal.  Back-patch to
9.4 (all supported versions).

Reviewed by Daniel Gustafsson and Kyotaro HORIGUCHI.

Discussion: https://postgr.es/m/20180812064815.GB2301738@rfd.leadboat.com
This commit is contained in:
Noah Misch
2019-03-31 19:32:48 -07:00
parent d02abc2e96
commit e49dc9ab14
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/utils/init/miscinit.c
View File

@@ -970,14 +970,10 @@ CreateLockFile(const char *filename, bool amPostmaster,
if (PGSharedMemoryIsInUse(id1, id2)) if (PGSharedMemoryIsInUse(id1, id2))
ereport(FATAL, ereport(FATAL,
(errcode(ERRCODE_LOCK_FILE_EXISTS), (errcode(ERRCODE_LOCK_FILE_EXISTS),
errmsg("pre-existing shared memory block " errmsg("pre-existing shared memory block (key %lu, ID %lu) is still in use",
"(key %lu, ID %lu) is still in use",
id1, id2), id1, id2),
errhint("If you're sure there are no old " errhint("Terminate any old server processes associated with data directory \"%s\".",
"server processes still running, remove " refName)));
"the shared memory block "
"or just delete the file \"%s\".",
filename)));
} }
} }