1
0
mirror of https://github.com/postgres/postgres.git synced 2025-11-28 11:44:57 +03:00

Move isolation test index-killtuples to src/test/modules/index/

index-killtuples test depends on the contrib modules btree_gin and
btree_gist, which would not be installed in a temporary installation
with an execution of the main isolation test suite like this one:
make -C src/test/isolation/ check

src/test/isolation/ should not depend on contrib/, and EXTRA_INSTALL has
no effect in this case as this test suite uses its own Makefile rules.

This commit moves index-killtuples into its new module, called "index",
whose name looks like the best fit there can be as it depends on more
than one index AM.  btree_gin and btree_gist are now pulled in the
temporary installation with EXTRA_INSTALL.  The test is renamed to
"killtuples", for simplicity.

Author: Nazir Bilal Yavuz <byavuz81@gmail.com>
Suggested-by: Andres Freund <andres@anarazel.de>
Suggested-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/aKJsWedftW7UX1WM@paquier.xyz
This commit is contained in:
Michael Paquier
2025-11-24 19:33:51 +09:00
parent d4c0f91f7d
commit e429c3cecb
8 changed files with 36 additions and 1 deletions

View File

@@ -16,7 +16,6 @@ test: ri-trigger
test: partial-index test: partial-index
test: two-ids test: two-ids
test: multiple-row-versions test: multiple-row-versions
test: index-killtuples
test: index-only-scan test: index-only-scan
test: index-only-bitmapscan test: index-only-bitmapscan
test: predicate-lock-hot-tuple test: predicate-lock-hot-tuple

View File

@@ -10,6 +10,7 @@ SUBDIRS = \
delay_execution \ delay_execution \
dummy_index_am \ dummy_index_am \
dummy_seclabel \ dummy_seclabel \
index \
libpq_pipeline \ libpq_pipeline \
oauth_validator \ oauth_validator \
plsample \ plsample \

6
src/test/modules/index/.gitignore vendored Normal file
View File

@@ -0,0 +1,6 @@
# Generated subdirectories
/log/
/results/
/output_iso/
/tmp_check/
/tmp_check_iso/

View File

@@ -0,0 +1,16 @@
# src/test/modules/index/Makefile
EXTRA_INSTALL = contrib/btree_gin contrib/btree_gist
ISOLATION = killtuples
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
include $(PGXS)
else
subdir = src/test/modules/index
top_builddir = ../../../..
include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif

View File

@@ -0,0 +1,12 @@
# Copyright (c) 2025, PostgreSQL Global Development Group
tests += {
'name': 'index',
'sd': meson.current_source_dir(),
'bd': meson.current_build_dir(),
'isolation': {
'specs': [
'killtuples',
],
},
}

View File

@@ -6,6 +6,7 @@ subdir('delay_execution')
subdir('dummy_index_am') subdir('dummy_index_am')
subdir('dummy_seclabel') subdir('dummy_seclabel')
subdir('gin') subdir('gin')
subdir('index')
subdir('injection_points') subdir('injection_points')
subdir('ldap_password_func') subdir('ldap_password_func')
subdir('libpq_pipeline') subdir('libpq_pipeline')