database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-23 14:01:44 +03:00
Code Activity

Backpatch tuplesort.c assertion.

Browse Source 
Backpatch an assertion (that was originally added to Postgres 12 by
commit dd299df818) that seems broadly useful.  The assertion can detect
violations of the HOT invariant (i.e. no two index tuples can point to
the same heap TID) when CREATE INDEX somehow incorrectly allows that to
take place.

For example, a IndexBuildHeapScan/heapam_index_build_range_scan bug
might result in two tuples that both point to the same heap TID.  If
these two tuples also happen to be duplicates, the assertion will fail.

Discussion: https://postgr.es/m/CAH2-WzmBxu4o=pMsniur+bwHqCGCmV_AOLkuK6BuU7ngA6evqw@mail.gmail.com
Backpatch: 9.5-11 only
This commit is contained in:
Peter Geoghegan
2020-07-29 16:00:50 -07:00
parent 8a60f541f3
commit e3ba932da3
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/sort/tuplesort.c
View File

@ -4536,6 +4536,9 @@ comparetup_index_btree(const SortTuple *a, const SortTuple *b,
return (pos1 < pos2) ? -1 : 1; return (pos1 < pos2) ? -1 : 1;
} }
/* ItemPointer values should never be equal */
Assert(false);
return 0; return 0;
} }
@ -4585,6 +4588,9 @@ comparetup_index_hash(const SortTuple *a, const SortTuple *b,
return (pos1 < pos2) ? -1 : 1; return (pos1 < pos2) ? -1 : 1;
} }
/* ItemPointer values should never be equal */
Assert(false);
return 0; return 0;
} }