database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

Initial pgindent run with pg_bsd_indent version 2.0.

Browse Source 
The new indent version includes numerous fixes thanks to Piotr Stefaniak.
The main changes visible in this commit are:

* Nicer formatting of function-pointer declarations.
* No longer unexpectedly removes spaces in expressions using casts,
  sizeof, or offsetof.
* No longer wants to add a space in "struct structname *varname", as
  well as some similar cases for const- or volatile-qualified pointers.
* Declarations using PG_USED_FOR_ASSERTS_ONLY are formatted more nicely.
* Fixes bug where comments following declarations were sometimes placed
  with no space separating them from the code.
* Fixes some odd decisions for comments following case labels.
* Fixes some cases where comments following code were indented to less
  than the expected column 33.

On the less good side, it now tends to put more whitespace around typedef
names that are not listed in typedefs.list.  This might encourage us to
put more effort into typedef name collection; it's not really a bug in
indent itself.

There are more changes coming after this round, having to do with comment
indentation and alignment of lines appearing within parentheses.  I wanted
to limit the size of the diffs to something that could be reviewed without
one's eyes completely glazing over, so it seemed better to split up the
changes as much as practical.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2017-06-21 14:39:04 -04:00
parent 8ff6d4ec78
commit e3860ffa4d
379 changed files with 1725 additions and 1707 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/interfaces/ecpg/ecpglib/execute.c
View File

@ -82,7 +82,7 @@ quote_postgres(char *arg, bool quote, int lineno)
}
static void
free_variable(struct variable * var)
free_variable(struct variable *var)
{
struct variable *var_next;
@ -95,7 +95,7 @@ free_variable(struct variable * var)
}
static void
free_statement(struct statement * stmt)
free_statement(struct statement *stmt)
{
if (stmt == NULL)
return;
@ -145,7 +145,7 @@ next_insert(char *text, int pos, bool questionmarks)
}
static bool
ecpg_type_infocache_push(struct ECPGtype_information_cache ** cache, int oid, enum ARRAY_TYPE isarray, int lineno)
ecpg_type_infocache_push(struct ECPGtype_information_cache **cache, int oid, enum ARRAY_TYPE isarray, int lineno)
{
struct ECPGtype_information_cache *new_entry
= (struct ECPGtype_information_cache *) ecpg_alloc(sizeof(struct ECPGtype_information_cache), lineno);
@ -161,7 +161,7 @@ ecpg_type_infocache_push(struct ECPGtype_information_cache ** cache, int oid, en
}
static enum ARRAY_TYPE
ecpg_is_type_an_array(int type, const struct statement * stmt, const struct variable * var)
ecpg_is_type_an_array(int type, const struct statement *stmt, const struct variable *var)
{
char *array_query;
enum ARRAY_TYPE isarray = ECPG_ARRAY_NOT_SET;
@ -307,7 +307,7 @@ ecpg_is_type_an_array(int type, const struct statement * stmt, const struct vari
bool
ecpg_store_result(const PGresult *results, int act_field,
const struct statement * stmt, struct variable * var)
const struct statement *stmt, struct variable *var)
{
enum ARRAY_TYPE isarray;
int act_tuple,
@ -491,7 +491,7 @@ sprintf_float_value(char *ptr, float value, const char *delim)
}
bool
ecpg_store_input(const int lineno, const bool force_indicator, const struct variable * var,
ecpg_store_input(const int lineno, const bool force_indicator, const struct variable *var,
char **tobeinserted_p, bool quote)
{
char *mallocedval = NULL;
@ -1049,7 +1049,7 @@ ecpg_store_input(const int lineno, const bool force_indicator, const struct vari
}
void
ecpg_free_params(struct statement * stmt, bool print)
ecpg_free_params(struct statement *stmt, bool print)
{
int n;
@ -1065,7 +1065,7 @@ ecpg_free_params(struct statement * stmt, bool print)
}
static bool
insert_tobeinserted(int position, int ph_len, struct statement * stmt, char *tobeinserted)
insert_tobeinserted(int position, int ph_len, struct statement *stmt, char *tobeinserted)
{
char *newcopy;
@ -1104,7 +1104,7 @@ insert_tobeinserted(int position, int ph_len, struct statement * stmt, char *tob
* in arrays which can be used by PQexecParams().
*/
bool
ecpg_build_params(struct statement * stmt)
ecpg_build_params(struct statement *stmt)
{
struct variable *var;
int desc_counter = 0;
@ -1402,7 +1402,7 @@ ecpg_build_params(struct statement * stmt)
* If we are in non-autocommit mode, automatically start a transaction.
*/
bool
ecpg_autostart_transaction(struct statement * stmt)
ecpg_autostart_transaction(struct statement *stmt)
{
if (PQtransactionStatus(stmt->connection->connection) == PQTRANS_IDLE && !stmt->connection->autocommit)
{
@ -1423,7 +1423,7 @@ ecpg_autostart_transaction(struct statement * stmt)
* Execute the SQL statement.
*/
bool
ecpg_execute(struct statement * stmt)
ecpg_execute(struct statement *stmt)
{
ecpg_log("ecpg_execute on line %d: query: %s; with %d parameter(s) on connection %s\n", stmt->lineno, stmt->command, stmt->nparams, stmt->connection->name);
if (stmt->statement_type == ECPGst_execute)
@ -1471,7 +1471,7 @@ ecpg_execute(struct statement * stmt)
*-------
*/
bool
ecpg_process_output(struct statement * stmt, bool clear_result)
ecpg_process_output(struct statement *stmt, bool clear_result)
{
struct variable *var;
bool status = false;
@ -1747,7 +1747,7 @@ bool
ecpg_do_prologue(int lineno, const int compat, const int force_indicator,
const char *connection_name, const bool questionmarks,
enum ECPG_statement_type statement_type, const char *query,
va_list args, struct statement ** stmt_out)
va_list args, struct statement **stmt_out)
{
struct statement *stmt;
struct connection *con;
@ -1976,7 +1976,7 @@ ecpg_do_prologue(int lineno, const int compat, const int force_indicator,
* Restore the application locale and free the statement structure.
*/
void
ecpg_do_epilogue(struct statement * stmt)
ecpg_do_epilogue(struct statement *stmt)
{
if (stmt == NULL)
return;