Initial pgindent run with pg_bsd_indent version 2.0.

The new indent version includes numerous fixes thanks to Piotr Stefaniak.
The main changes visible in this commit are:

* Nicer formatting of function-pointer declarations.
* No longer unexpectedly removes spaces in expressions using casts,
  sizeof, or offsetof.
* No longer wants to add a space in "struct structname *varname", as
  well as some similar cases for const- or volatile-qualified pointers.
* Declarations using PG_USED_FOR_ASSERTS_ONLY are formatted more nicely.
* Fixes bug where comments following declarations were sometimes placed
  with no space separating them from the code.
* Fixes some odd decisions for comments following case labels.
* Fixes some cases where comments following code were indented to less
  than the expected column 33.

On the less good side, it now tends to put more whitespace around typedef
names that are not listed in typedefs.list.  This might encourage us to
put more effort into typedef name collection; it's not really a bug in
indent itself.

There are more changes coming after this round, having to do with comment
indentation and alignment of lines appearing within parentheses.  I wanted
to limit the size of the diffs to something that could be reviewed without
one's eyes completely glazing over, so it seemed better to split up the
changes as much as practical.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us

src/include/replication/logical.h

@@ -19,17 +19,17 @@ struct LogicalDecodingContext;
 
 typedef void (*LogicalOutputPluginWriterWrite) (
 										   struct LogicalDecodingContext *lr,
-															XLogRecPtr Ptr,
-															TransactionId xid,
-															bool last_write
+												XLogRecPtr Ptr,
+												TransactionId xid,
+												bool last_write
 );
 
 typedef LogicalOutputPluginWriterWrite LogicalOutputPluginWriterPrepareWrite;
 
 typedef void (*LogicalOutputPluginWriterUpdateProgress) (
 										   struct LogicalDecodingContext *lr,
-															  XLogRecPtr Ptr,
-															TransactionId xid
+														 XLogRecPtr Ptr,
+														 TransactionId xid
 );
 
 typedef struct LogicalDecodingContext

src/include/replication/output_plugin.h

@@ -42,47 +42,47 @@ typedef void (*LogicalOutputPluginInit) (struct OutputPluginCallbacks *cb);
  * the same slot is used from there one, it will be "false".
  */
 typedef void (*LogicalDecodeStartupCB) (struct LogicalDecodingContext *ctx,
-												OutputPluginOptions *options,
-													bool is_init);
+										OutputPluginOptions *options,
+										bool is_init);
 
 /*
  * Callback called for every (explicit or implicit) BEGIN of a successful
  * transaction.
  */
 typedef void (*LogicalDecodeBeginCB) (struct LogicalDecodingContext *ctx,
-												  ReorderBufferTXN *txn);
+									  ReorderBufferTXN *txn);
 
 /*
  * Callback for every individual change in a successful transaction.
  */
 typedef void (*LogicalDecodeChangeCB) (struct LogicalDecodingContext *ctx,
-												   ReorderBufferTXN *txn,
-												   Relation relation,
-												ReorderBufferChange *change);
+									   ReorderBufferTXN *txn,
+									   Relation relation,
+									   ReorderBufferChange *change);
 
 /*
  * Called for every (explicit or implicit) COMMIT of a successful transaction.
  */
 typedef void (*LogicalDecodeCommitCB) (struct LogicalDecodingContext *ctx,
-												   ReorderBufferTXN *txn,
-												   XLogRecPtr commit_lsn);
+									   ReorderBufferTXN *txn,
+									   XLogRecPtr commit_lsn);
 
 /*
  * Called for the generic logical decoding messages.
  */
 typedef void (*LogicalDecodeMessageCB) (struct LogicalDecodingContext *ctx,
-													ReorderBufferTXN *txn,
-													XLogRecPtr message_lsn,
-													bool transactional,
-													const char *prefix,
-													Size message_size,
-													const char *message);
+										ReorderBufferTXN *txn,
+										XLogRecPtr message_lsn,
+										bool transactional,
+										const char *prefix,
+										Size message_size,
+										const char *message);
 
 /*
  * Filter changes by origin.
  */
 typedef bool (*LogicalDecodeFilterByOriginCB) (struct LogicalDecodingContext *ctx,
-													  RepOriginId origin_id);
+											   RepOriginId origin_id);
 
 /*
  * Called to shutdown an output plugin.

src/include/replication/reorderbuffer.h

@@ -276,30 +276,30 @@ typedef struct ReorderBuffer ReorderBuffer;
 
 /* change callback signature */
 typedef void (*ReorderBufferApplyChangeCB) (
-														ReorderBuffer *rb,
-														ReorderBufferTXN *txn,
-														Relation relation,
-												ReorderBufferChange *change);
+											ReorderBuffer *rb,
+											ReorderBufferTXN *txn,
+											Relation relation,
+											ReorderBufferChange *change);
 
 /* begin callback signature */
 typedef void (*ReorderBufferBeginCB) (
-												  ReorderBuffer *rb,
-												  ReorderBufferTXN *txn);
+									  ReorderBuffer *rb,
+									  ReorderBufferTXN *txn);
 
 /* commit callback signature */
 typedef void (*ReorderBufferCommitCB) (
-												   ReorderBuffer *rb,
-												   ReorderBufferTXN *txn,
-												   XLogRecPtr commit_lsn);
+									   ReorderBuffer *rb,
+									   ReorderBufferTXN *txn,
+									   XLogRecPtr commit_lsn);
 
 /* message callback signature */
 typedef void (*ReorderBufferMessageCB) (
-													ReorderBuffer *rb,
-													ReorderBufferTXN *txn,
-													XLogRecPtr message_lsn,
-													bool transactional,
-												 const char *prefix, Size sz,
-													const char *message);
+										ReorderBuffer *rb,
+										ReorderBufferTXN *txn,
+										XLogRecPtr message_lsn,
+										bool transactional,
+										const char *prefix, Size sz,
+										const char *message);
 
 struct ReorderBuffer
 {

src/include/replication/walreceiver.h

@@ -192,33 +192,33 @@ typedef struct WalRcvExecResult
 
 /* libpqwalreceiver hooks */
 typedef WalReceiverConn *(*walrcv_connect_fn) (const char *conninfo, bool logical,
-														 const char *appname,
-														   char **err);
+											   const char *appname,
+											   char **err);
 typedef void (*walrcv_check_conninfo_fn) (const char *conninfo);
 typedef char *(*walrcv_get_conninfo_fn) (WalReceiverConn *conn);
 typedef char *(*walrcv_identify_system_fn) (WalReceiverConn *conn,
-													 TimeLineID *primary_tli,
-														int *server_version);
+											TimeLineID *primary_tli,
+											int *server_version);
 typedef void (*walrcv_readtimelinehistoryfile_fn) (WalReceiverConn *conn,
-															   TimeLineID tli,
-															 char **filename,
-												  char **content, int *size);
+												   TimeLineID tli,
+												   char **filename,
+												   char **content, int *size);
 typedef bool (*walrcv_startstreaming_fn) (WalReceiverConn *conn,
-										 const WalRcvStreamOptions *options);
+										  const WalRcvStreamOptions *options);
 typedef void (*walrcv_endstreaming_fn) (WalReceiverConn *conn,
-													TimeLineID *next_tli);
+										TimeLineID *next_tli);
 typedef int (*walrcv_receive_fn) (WalReceiverConn *conn, char **buffer,
-											  pgsocket *wait_fd);
+								  pgsocket *wait_fd);
 typedef void (*walrcv_send_fn) (WalReceiverConn *conn, const char *buffer,
-											int nbytes);
+								int nbytes);
 typedef char *(*walrcv_create_slot_fn) (WalReceiverConn *conn,
 										const char *slotname, bool temporary,
-										   CRSSnapshotAction snapshot_action,
-													XLogRecPtr *lsn);
+										CRSSnapshotAction snapshot_action,
+										XLogRecPtr *lsn);
 typedef WalRcvExecResult *(*walrcv_exec_fn) (WalReceiverConn *conn,
-														 const char *query,
-														 const int nRetTypes,
-														 const Oid *retTypes);
+											 const char *query,
+											 const int nRetTypes,
+											 const Oid *retTypes);
 typedef void (*walrcv_disconnect_fn) (WalReceiverConn *conn);
 
 typedef struct WalReceiverFunctionsType