database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-06 13:46:51 +03:00
Code Activity

Initial pgindent run with pg_bsd_indent version 2.0.

Browse Source 
The new indent version includes numerous fixes thanks to Piotr Stefaniak.
The main changes visible in this commit are:

* Nicer formatting of function-pointer declarations.
* No longer unexpectedly removes spaces in expressions using casts,
  sizeof, or offsetof.
* No longer wants to add a space in "struct structname *varname", as
  well as some similar cases for const- or volatile-qualified pointers.
* Declarations using PG_USED_FOR_ASSERTS_ONLY are formatted more nicely.
* Fixes bug where comments following declarations were sometimes placed
  with no space separating them from the code.
* Fixes some odd decisions for comments following case labels.
* Fixes some cases where comments following code were indented to less
  than the expected column 33.

On the less good side, it now tends to put more whitespace around typedef
names that are not listed in typedefs.list.  This might encourage us to
put more effort into typedef name collection; it's not really a bug in
indent itself.

There are more changes coming after this round, having to do with comment
indentation and alignment of lines appearing within parentheses.  I wanted
to limit the size of the diffs to something that could be reviewed without
one's eyes completely glazing over, so it seemed better to split up the
changes as much as practical.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2017-06-21 14:39:04 -04:00
parent 8ff6d4ec78
commit e3860ffa4d
379 changed files with 1725 additions and 1707 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/regex/regc_locale.c
View File

@@ -56,7 +56,7 @@ static const struct cname
{
const char *name;
const char code;
} cnames[] =
} cnames[] =
{
{
@@ -377,7 +377,7 @@ enum classes
* element - map collating-element name to chr
*/
static chr
element(struct vars * v, /* context */
element(struct vars *v, /* context */
const chr *startp, /* points to start of name */
const chr *endp) /* points just past end of name */
{
@@ -413,7 +413,7 @@ element(struct vars * v, /* context */
* range - supply cvec for a range, including legality check
*/
static struct cvec *
range(struct vars * v, /* context */
range(struct vars *v, /* context */
chr a, /* range start */
chr b, /* range end, might equal a */
int cases) /* case-independent? */
@@ -505,7 +505,7 @@ before(chr x, chr y)
* Must include case counterparts on request.
*/
static struct cvec *
eclass(struct vars * v, /* context */
eclass(struct vars *v, /* context */
chr c, /* Collating element representing the
* equivalence class. */
int cases) /* all cases? */
@@ -545,14 +545,14 @@ eclass(struct vars * v, /* context */
* because callers are not supposed to explicitly free the result either way.
*/
static struct cvec *
cclass(struct vars * v, /* context */
cclass(struct vars *v, /* context */
const chr *startp, /* where the name starts */
const chr *endp, /* just past the end of the name */
int cases) /* case-independent? */
{
size_t len;
struct cvec *cv = NULL;
const char *const * namePtr;
const char *const *namePtr;
int i,
index;
@@ -669,7 +669,7 @@ cclass(struct vars * v, /* context */
* cclass_column_index - get appropriate high colormap column index for chr
*/
static int
cclass_column_index(struct colormap * cm, chr c)
cclass_column_index(struct colormap *cm, chr c)
{
int colnum = 0;
@@ -713,7 +713,7 @@ cclass_column_index(struct colormap * cm, chr c)
* messy cases are done via range().
*/
static struct cvec *
allcases(struct vars * v, /* context */
allcases(struct vars *v, /* context */
chr c) /* character to get case equivs of */
{
struct cvec *cv;