database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-21 12:05:57 +03:00
Code

Fix the test for decoding of two-phase transactions.

Browse Source 
Commit 5a3574d7b3 added the test for decoding of two-phase transactions
during the build of a consistent snapshot. The test forgot to skip empty
xacts which can lead to decoding of extra empty transactions due to
background activity by autovacuum.

Per report by buildfarm.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/363512.1610171267@sss.pgh.pa.us
This commit is contained in:
Amit Kapila 2021-01-09 15:45:38 +05:30
parent 39d4a15310
commit e33d004900
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/test_decoding/expected/twophase_snapshot.out
View File

@ -22,14 +22,14 @@ step s1init: <... completed>
init init
step s1insert: INSERT INTO do_write DEFAULT VALUES; step s1insert: INSERT INTO do_write DEFAULT VALUES;
step s1start: SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', 'false', 'two-phase-commit', '1'); step s1start: SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', 'false', 'skip-empty-xacts', '1', 'two-phase-commit', '1');
data data
BEGIN BEGIN
table public.do_write: INSERT: id[integer]:2 table public.do_write: INSERT: id[integer]:2
COMMIT COMMIT
step s2cp: COMMIT PREPARED 'test1'; step s2cp: COMMIT PREPARED 'test1';
step s1start: SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', 'false', 'two-phase-commit', '1'); step s1start: SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', 'false', 'skip-empty-xacts', '1', 'two-phase-commit', '1');
data data
BEGIN BEGIN

2
contrib/test_decoding/specs/twophase_snapshot.spec
View File

@ -16,7 +16,7 @@ session "s1"
setup { SET synchronous_commit=on; } setup { SET synchronous_commit=on; }
step "s1init" {SELECT 'init' FROM pg_create_logical_replication_slot('isolation_slot', 'test_decoding');} step "s1init" {SELECT 'init' FROM pg_create_logical_replication_slot('isolation_slot', 'test_decoding');}
step "s1start" {SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', 'false', 'two-phase-commit', '1');} step "s1start" {SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', 'false', 'skip-empty-xacts', '1', 'two-phase-commit', '1');}
step "s1insert" { INSERT INTO do_write DEFAULT VALUES; } step "s1insert" { INSERT INTO do_write DEFAULT VALUES; }
session "s2" session "s2"