database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-02 11:44:50 +03:00
Code

Free pre-modification HeapTuple in ALTER TABLE ... TYPE ...

Browse Source 
This was an oversight in commit 3b174b1a3.

Per offline gripe from Alvaro Herrera

Backpatch to release 11.
This commit is contained in:
Andrew Dunstan 2019-01-11 17:12:54 -05:00
parent 1db5667bac
commit e33884d412
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/commands/tablecmds.c
View File

@ -9648,6 +9648,7 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
Datum valuesAtt[Natts_pg_attribute]; Datum valuesAtt[Natts_pg_attribute];
bool nullsAtt[Natts_pg_attribute]; bool nullsAtt[Natts_pg_attribute];
bool replacesAtt[Natts_pg_attribute]; bool replacesAtt[Natts_pg_attribute];
HeapTuple newTup;
MemSet(valuesAtt, 0, sizeof(valuesAtt)); MemSet(valuesAtt, 0, sizeof(valuesAtt));
MemSet(nullsAtt, false, sizeof(nullsAtt)); MemSet(nullsAtt, false, sizeof(nullsAtt));
@ -9673,8 +9674,10 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
replacesAtt[Anum_pg_attribute_attmissingval - 1] = true; replacesAtt[Anum_pg_attribute_attmissingval - 1] = true;
nullsAtt[Anum_pg_attribute_attmissingval - 1] = false; nullsAtt[Anum_pg_attribute_attmissingval - 1] = false;
heapTup = heap_modify_tuple(heapTup, RelationGetDescr(attrelation), newTup = heap_modify_tuple(heapTup, RelationGetDescr(attrelation),
valuesAtt, nullsAtt, replacesAtt); valuesAtt, nullsAtt, replacesAtt);
heap_freetuple(heapTup);
heapTup = newTup;
attTup = (Form_pg_attribute) GETSTRUCT(heapTup); attTup = (Form_pg_attribute) GETSTRUCT(heapTup);
} }
} }