From e2fe0aedd00eae89e6d00bca5c598d1ac31b266a Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Mon, 22 Aug 2022 15:08:45 +0200 Subject: [PATCH] doc: Minor wordsmithing to COPY docs Perform some minor wordsmithing on two sentences in the COPY documentation to make them clearer. While there, also ensure to wrap a few occurrences of CSV in which were missing this. Reported-by: Eric Mutta Reviewed-by: Tom Lane Discussion: https://postgr.es/m/166104548566.654.11680826843612576896@wrigleys.postgresql.org --- doc/src/sgml/ref/copy.sgml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml index 63afa0d97e0..c25b52d0cb2 100644 --- a/doc/src/sgml/ref/copy.sgml +++ b/doc/src/sgml/ref/copy.sgml @@ -157,10 +157,10 @@ COPY { table_name [ ( Note that the command is invoked by the shell, so if you need to pass - any arguments to shell command that come from an untrusted source, you + any arguments that come from an untrusted source, you must be careful to strip or escape any special characters that might have a special meaning for the shell. For security reasons, it is best - to use a fixed command string, or at least avoid passing any user input + to use a fixed command string, or at least avoid including any user input in it. @@ -227,7 +227,7 @@ COPY { table_name [ ( Note that all other sessions will immediately be able to see the data once it has been successfully loaded. This violates the normal rules - of MVCC visibility and users specifying should be aware of the + of MVCC visibility and users should be aware of the potential problems this might cause. @@ -708,7 +708,7 @@ COPY count Separated Value (CSV) file format used by many other programs, such as spreadsheets. Instead of the escaping rules used by PostgreSQL's standard text format, it - produces and recognizes the common CSV escaping mechanism. + produces and recognizes the common CSV escaping mechanism. @@ -766,7 +766,7 @@ COPY count - CSV format will both recognize and produce CSV files with quoted + CSV format will both recognize and produce CSV files with quoted values containing embedded carriage returns and line feeds. Thus the files are not strictly one line per table row like text-format files. @@ -775,7 +775,7 @@ COPY count - Many programs produce strange and occasionally perverse CSV files, + Many programs produce strange and occasionally perverse CSV files, so the file format is more a convention than a standard. Thus you might encounter some files that cannot be imported using this mechanism, and COPY might produce files that other