database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-13 07:41:39 +03:00
Code Activity

Fix gist_bool_ops to use gbtreekey2

Browse Source 
Commit 57e3c5160b added a new GiST bool opclass, but it used gbtreekey4
to store the data, which left two bytes undefined, as reported by skink,
our valgrind animal. There was a bit more confusion, because the opclass
also used gbtreekey8 in the definition.

Fix by defining a new gbtreekey2 struct, and using it in all the places.

Discussion: https://postgr.es/m/CAE2gYzyDKJBZngssR84VGZEN=Ux=V9FV23QfPgo+7-yYnKKg4g@mail.gmail.com
This commit is contained in:
Tomas Vondra
2021-11-08 01:14:55 +01:00
parent ccf289745d
commit e2fbb88372
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/btree_gist/btree_bool.c
View File

@ -72,7 +72,7 @@ static const gbtree_ninfo tinfo =
{
gbt_t_bool,
sizeof(bool),
4, /* sizeof(gbtreekey4) */
2, /* sizeof(gbtreekey2) */
gbt_boolgt,
gbt_boolge,
gbt_booleq,