database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-29 22:49:41 +03:00
Code Activity

Fix memory leaks in pg_combinebackup/reconstruct.c.

Browse Source 
One code path forgot to free the separately-malloc'd filename
part of a struct rfile.  Another place freed the filename but
forgot the struct rfile itself.  These seem worth fixing because
with a large backup we could be dealing with many files.

Coverity found the bug in make_rfile().  I found the other one
by manual inspection.
This commit is contained in:
Tom Lane
2025-10-22 13:38:37 -04:00
parent 6ff7ba9fe5
commit e2072b47b9
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_combinebackup/reconstruct.c
View File

@@ -370,6 +370,7 @@ reconstruct_from_incremental_file(char *input_filename,
if (s->relative_block_numbers != NULL) if (s->relative_block_numbers != NULL)
pfree(s->relative_block_numbers); pfree(s->relative_block_numbers);
pg_free(s->filename); pg_free(s->filename);
pg_free(s);
} }
pfree(sourcemap); pfree(sourcemap);
pfree(offsetmap); pfree(offsetmap);
@@ -517,6 +518,7 @@ make_rfile(char *filename, bool missing_ok)
{ {
if (missing_ok && errno == ENOENT) if (missing_ok && errno == ENOENT)
{ {
pg_free(rf->filename);
pg_free(rf); pg_free(rf);
return NULL; return NULL;
} }