database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-20 00:42:27 +03:00
Code

aio: Minor comment improvements

Browse Source 
Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/usbwzckj7q3jhfx3ann3nrfnukmupbs35axvq5zfyeo6nvrzrm@onjhxs2du4st
This commit is contained in:
Andres Freund 2025-04-01 16:06:48 -04:00
parent fdd146a8ef
commit e19dc74491
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/storage/smgr/md.c
View File

@ -1981,7 +1981,7 @@ md_readv_complete(PgAioHandle *ioh, PgAioResult prior_result, uint8 cb_data)
* might not process the query result immediately (because it is busy * might not process the query result immediately (because it is busy
* doing another part of query processing) or at all (e.g. if it was * doing another part of query processing) or at all (e.g. if it was
* cancelled or errored out due to another IO also failing). The * cancelled or errored out due to another IO also failing). The
* issuer of the IO will emit an ERROR when processing the IO's * definer of the IO will emit an ERROR when processing the IO's
* results * results
*/ */
pgaio_result_report(result, td, LOG_SERVER_ONLY); pgaio_result_report(result, td, LOG_SERVER_ONLY);

8
src/backend/storage/smgr/smgr.c
View File

@ -738,6 +738,14 @@ smgrreadv(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
* blocks not successfully read might bear unspecified modifications, up to * blocks not successfully read might bear unspecified modifications, up to
* the full nblocks). This maintains the abstraction that smgr operates on the * the full nblocks). This maintains the abstraction that smgr operates on the
* level of blocks, rather than bytes. * level of blocks, rather than bytes.
*
* Compared to smgrreadv(), more responsibilities fall on the caller:
* - Partial reads need to be handled by the caller re-issuing IO for the
* unread blocks
* - smgr will ereport(LOG_SERVER_ONLY) some problems, but higher layers are
* responsible for pgaio_result_report() to mirror that news to the user (if
* the IO results in PGAIO_RS_WARNING) or abort the (sub)transaction (if
* PGAIO_RS_ERROR).
*/ */
void void
smgrstartreadv(PgAioHandle *ioh, smgrstartreadv(PgAioHandle *ioh,