database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-12 21:01:52 +03:00
Code Activity

Fix obsolete comments referencing JoinPathExtraData.extra_lateral_rels.

Browse Source 
That field went away in commit edca44b15, but it seems that
commit 45be99f8c re-introduced some comments mentioning it.
Noted by James Coleman, though this isn't exactly his
proposed new wording.  Also thanks to Justin Pryzby for
software archaeology.

Discussion: https://postgr.es/m/CAAaqYe8fxZjq3na+XkNx4C78gDqykH-7dbnzygm9Qa9nuDTePg@mail.gmail.com
This commit is contained in:
Tom Lane
2021-04-14 14:28:17 -04:00
parent 9acaf1a621
commit e1623b7d86
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/optimizer/path/joinpath.c
View File

@ -670,8 +670,8 @@ try_partial_nestloop_path(PlannerInfo *root,
/* /*
* If the inner path is parameterized, the parameterization must be fully * If the inner path is parameterized, the parameterization must be fully
* satisfied by the proposed outer path. Parameterized partial paths are * satisfied by the proposed outer path. Parameterized partial paths are
* not supported. The caller should already have verified that no * not supported. The caller should already have verified that no lateral
* extra_lateral_rels are required here. * rels are required here.
*/ */
Assert(bms_is_empty(joinrel->lateral_relids)); Assert(bms_is_empty(joinrel->lateral_relids));
if (inner_path->param_info != NULL) if (inner_path->param_info != NULL)
@ -984,8 +984,8 @@ try_partial_hashjoin_path(PlannerInfo *root,
/* /*
* If the inner path is parameterized, the parameterization must be fully * If the inner path is parameterized, the parameterization must be fully
* satisfied by the proposed outer path. Parameterized partial paths are * satisfied by the proposed outer path. Parameterized partial paths are
* not supported. The caller should already have verified that no * not supported. The caller should already have verified that no lateral
* extra_lateral_rels are required here. * rels are required here.
*/ */
Assert(bms_is_empty(joinrel->lateral_relids)); Assert(bms_is_empty(joinrel->lateral_relids));
if (inner_path->param_info != NULL) if (inner_path->param_info != NULL)
@ -1714,7 +1714,7 @@ match_unsorted_outer(PlannerInfo *root,
* partial path and the joinrel is parallel-safe. However, we can't * partial path and the joinrel is parallel-safe. However, we can't
* handle JOIN_UNIQUE_OUTER, because the outer path will be partial, and * handle JOIN_UNIQUE_OUTER, because the outer path will be partial, and
* therefore we won't be able to properly guarantee uniqueness. Nor can * therefore we won't be able to properly guarantee uniqueness. Nor can
* we handle extra_lateral_rels, since partial paths must not be * we handle joins needing lateral rels, since partial paths must not be
* parameterized. Similarly, we can't handle JOIN_FULL and JOIN_RIGHT, * parameterized. Similarly, we can't handle JOIN_FULL and JOIN_RIGHT,
* because they can produce false null extended rows. * because they can produce false null extended rows.
*/ */