database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-02 11:44:50 +03:00
Code

The current implementation of BlobInputStream does

Browse Source 
not properly handle 8-bit unsigned data as it blindly
casts the byte to an int, which java most helpfully
promotes to a signed type.  This causes problems when
you can only return -1 to indicated EOF.

The following patch fixes the bug and has been tested
locally on image data.

Chad David
This commit is contained in:
Bruce Momjian 2001-05-16 03:29:01 +00:00
parent dbb219b896
commit e046e1dfab
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/interfaces/jdbc/org/postgresql/largeobject/BlobInputStream.java
View File

@ -64,10 +64,18 @@ public class BlobInputStream extends InputStream {
} }
// Handle EOF // Handle EOF
if(bpos>=buffer.length) if(bpos >= buffer.length) {
return -1; return -1;
}
return (int) buffer[bpos++]; int ret = (buffer[bpos] & 0x7F);
if ((buffer[bpos] &0x80) == 0x80) {
ret |= 0x80;
}
bpos++;
return ret;
} catch(SQLException se) { } catch(SQLException se) {
throw new IOException(se.toString()); throw new IOException(se.toString());
} }
@ -152,5 +160,4 @@ public class BlobInputStream extends InputStream {
public boolean markSupported() { public boolean markSupported() {
return true; return true;
} }
} }