1
0
mirror of https://github.com/postgres/postgres.git synced 2025-09-02 04:21:28 +03:00

Code cleanup, mostly in the smgr:

- Update comment in IsReservedName() to the present day

     - Improve some variable & function names in commands/vacuum.c. I
       was planning to rewrite this to avoid lappend(), but since I
       still intend to do the list rewrite, there's no need for that.

     - Update some smgr comments which seemed to imply that we still
       forced all dirty pages to disk at commit-time.

     - Replace some #ifdef DIAGNOSTIC code with assertions.

     - Make the distinction between OS-level file descriptors and
       virtual file descriptors a little clearer in a few comments

     - Other minor comment improvements in the smgr code
This commit is contained in:
Neil Conway
2004-01-06 18:07:32 +00:00
parent 030f8e7313
commit dfc7e7b71d
6 changed files with 73 additions and 98 deletions

View File

@@ -11,7 +11,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/storage/smgr/smgr.c,v 1.67 2003/12/12 18:45:09 petere Exp $
* $PostgreSQL: pgsql/src/backend/storage/smgr/smgr.c,v 1.68 2004/01/06 18:07:31 neilc Exp $
*
*-------------------------------------------------------------------------
*/
@@ -382,7 +382,7 @@ smgrblindwrt(int16 which,
}
/*
* smgrnblocks() -- Calculate the number of POSTGRES blocks in the
* smgrnblocks() -- Calculate the number of blocks in the
* supplied relation.
*
* Returns the number of blocks on success, aborts the current
@@ -411,8 +411,8 @@ smgrnblocks(int16 which, Relation reln)
}
/*
* smgrtruncate() -- Truncate supplied relation to a specified number
* of blocks
* smgrtruncate() -- Truncate supplied relation to the specified number
* of blocks
*
* Returns the number of blocks on success, aborts the current
* transaction on failure.
@@ -444,7 +444,7 @@ smgrtruncate(int16 which, Relation reln, BlockNumber nblocks)
}
/*
* smgrDoPendingDeletes() -- take care of relation deletes at end of xact.
* smgrDoPendingDeletes() -- Take care of relation deletes at end of xact.
*/
int
smgrDoPendingDeletes(bool isCommit)
@@ -494,7 +494,7 @@ smgrDoPendingDeletes(bool isCommit)
* smgrcommit() -- Prepare to commit changes made during the current
* transaction.
*
* This is called before we actually commit.
* This is called before we actually commit.
*/
int
smgrcommit(void)
@@ -538,7 +538,7 @@ smgrabort(void)
}
/*
* Sync files to disk at checkpoint time.
* smgrsync() -- Sync files to disk at checkpoint time.
*/
int
smgrsync(void)