database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-20 00:42:27 +03:00
Code

Don't use elog() in src/port/pwrite.c.

Browse Source 
Nothing broke because of this oversight yet, but it would fail to link
if we tried to use pg_pwrite() in frontend code on a system that lacks
pwrite().  Use an assertion instead.  Also pgindent while here.

Discussion: https://postgr.es/m/CA%2BhUKGL57RvoQsS35TVPnQoPYqbtBixsdRhynB8NpcUKpHTTtg%40mail.gmail.com
This commit is contained in:
Thomas Munro 2021-01-13 19:11:09 +13:00
parent ee1b38f659
commit df10ac625c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/port/pwrite.c
View File

@ -137,14 +137,14 @@ pg_pwritev_with_retry(int fd, const struct iovec *iov, int iovcnt, off_t offset)
/* Are they all done? */ /* Are they all done? */
if (iovcnt == 0) if (iovcnt == 0)
{ {
if (part > 0) /* We don't expect the kernel to write more than requested. */
elog(ERROR, "unexpectedly wrote more than requested"); Assert(part == 0);
break; break;
} }
/* /*
* Move whatever's left to the front of our mutable copy and adjust the * Move whatever's left to the front of our mutable copy and adjust
* leading iovec. * the leading iovec.
*/ */
Assert(iovcnt > 0); Assert(iovcnt > 0);
memmove(iov_copy, iov, sizeof(*iov) * iovcnt); memmove(iov_copy, iov, sizeof(*iov) * iovcnt);