database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

I guess I'd vote for changing the code to be

Browse Source 
sys = malloc(strlen(editorName) + strlen(fname) + 10 + 1);
        if (!sys)
                return false;
        sprintf(sys, "exec '%s' '%s'", editorName, fname);

(note the added quotes to provide a little protection against spaces
and such).  Then it's perfectly obvious what the calculation is doing.
I don't care about wasting 20-some bytes, but confusing readers of the
code is worth avoiding.

                        regards, tom lane
This commit is contained in:
Bruce Momjian
2002-08-14 05:49:22 +00:00
parent 538b101595
commit dec918479f
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
doc/TODO
View File

@ -1,6 +1,6 @@
TODO list for PostgreSQL
========================
Last updated: Wed Aug 14 00:57:54 EDT 2002
Last updated: Wed Aug 14 01:46:11 EDT 2002
Current maintainer: Bruce Momjian (pgman@candle.pha.pa.us)
@ -205,7 +205,8 @@ Commands
o Add ALTER TABLE tab SET WITHOUT OIDS
* CLUSTER
o Cluster all tables at once
o Cluster all tables at once using pg_index.indisclustered or primary
key
o Prevent loss of indexes, permissions, inheritance
o Automatically maintain clustering on a table