database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

Dump all roles first, then all config settings on roles.

Browse Source 
This way, if a role's config setting uses the name of another role,
the validity of the dump isn't dependent on the order in which those
two roles are dumped.

Code by Phil Sorber, comment by me.
This commit is contained in:
Robert Haas
2011-10-14 14:16:02 -04:00
parent 393e828e31
commit dea95c7a7b
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/bin/pg_dump/pg_dumpall.c
View File

@ -804,11 +804,17 @@ dumpRoles(PGconn *conn)
buf, "ROLE", rolename); buf, "ROLE", rolename);
fprintf(OPF, "%s", buf->data); fprintf(OPF, "%s", buf->data);
if (server_version >= 70300)
dumpUserConfig(conn, rolename);
} }
/*
* Dump configuration settings for roles after all roles have been dumped.
* We do it this way because config settings for roles could mention the
* names of other roles.
*/
if (server_version >= 70300)
for (i = 0; i < PQntuples(res); i++)
dumpUserConfig(conn, PQgetvalue(res, i, i_rolname));
PQclear(res); PQclear(res);
fprintf(OPF, "\n\n"); fprintf(OPF, "\n\n");