database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-17 01:02:17 +03:00
Code Activity

pg_upgrade: Make format strings consistent

Browse Source 
The backport of commit f295494d33 introduced a format string using
%m.  This is not wrong, since those have been supported since commit
d6c55de1f9, but only commit 2c8118ee5d later introduced their use
in this file.  This use introduces a gratuitously different
translatable string and also makes it inconsistent with the rest of
the file.  To avoid that, switch this back to the old-style strerror()
route in the appropriate backbranches
This commit is contained in:
Peter Eisentraut
2025-08-08 00:27:14 +02:00
parent 7406a7d82c
commit de7fd83cda
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_upgrade/check.c
View File

@@ -1075,7 +1075,7 @@ check_for_not_null_inheritance(ClusterInfo *cluster)
for (int i = 0; i < ntup; i++) for (int i = 0; i < ntup; i++)
{ {
if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL) if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL)
pg_fatal("could not open file \"%s\": %m", output_path); pg_fatal("could not open file \"%s\": %s", output_path, strerror(errno));
if (!db_used) if (!db_used)
{ {
fprintf(script, "In database: %s\n", active_db->db_name); fprintf(script, "In database: %s\n", active_db->db_name);