database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-02 09:02:37 +03:00
Code Activity

Fix check for trapping exit() calls in libpq

Browse Source 
Commit e9bc0441f added an errorhint on the exit() check for libpq, but
accidentally changed the nm commandline to use -a instead of -A. These
options are similar enough to hide it in testing, but -a can also show
debugger symbols which isn't what we want. Fix by reverting the check
back to using -A again.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/bd2c8409-d6b3-5de9-ba0f-40c1381f630f@postgrespro.ru
This commit is contained in:
Daniel Gustafsson
2021-10-04 21:04:11 +02:00
parent c1aa3b3c0d
commit de744e9efb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/interfaces/libpq/Makefile
View File

@ -115,7 +115,7 @@ backend_src = $(top_srcdir)/src/backend
libpq-refs-stamp: $(shlib) libpq-refs-stamp: $(shlib)
ifneq ($(enable_coverage), yes) ifneq ($(enable_coverage), yes)
ifeq (,$(filter aix solaris,$(PORTNAME))) ifeq (,$(filter aix solaris,$(PORTNAME)))
@if nm -a -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \ @if nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \
echo 'libpq must not be calling any function which invokes exit'; exit 1; \ echo 'libpq must not be calling any function which invokes exit'; exit 1; \
fi fi
endif endif