From ddc22e8084918807a6c5e258bbc5c474a85ea274 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 11 Sep 2026 19:12:43 +0200 Subject: [PATCH] pg_ctl: Silence warnings about unused global variables Several global variables are only used in Windows build. This causes -Wunused-but-set-global warnings that the new clang 23 enables via -Wall. This commit marks these with an unused attribute to silence the warnings. (In the master branch, this is addressed differently, but for backpatching, this just silences the warnings without any behavior change.) Reviewed-by: Andreas Karlsson Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org --- src/bin/pg_ctl/pg_ctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c index e138c5b236e..d6ec6eb5273 100644 --- a/src/bin/pg_ctl/pg_ctl.c +++ b/src/bin/pg_ctl/pg_ctl.c @@ -78,7 +78,7 @@ typedef enum static bool do_wait = true; static int wait_seconds = DEFAULT_WAIT; -static bool wait_seconds_arg = false; +pg_attribute_unused() static bool wait_seconds_arg = false; static bool silent_mode = false; static ShutdownMode shutdown_mode = FAST_MODE; static int sig = SIGINT; /* default */ @@ -90,10 +90,10 @@ static char *post_opts = NULL; static const char *progname; static char *log_file = NULL; static char *exec_path = NULL; -static char *event_source = NULL; -static char *register_servicename = "PostgreSQL"; /* FIXME: + version ID? */ -static char *register_username = NULL; -static char *register_password = NULL; +pg_attribute_unused() static char *event_source = NULL; +pg_attribute_unused() static char *register_servicename = "PostgreSQL"; /* FIXME: + version ID? */ +pg_attribute_unused() static char *register_username = NULL; +pg_attribute_unused() static char *register_password = NULL; static char *argv0 = NULL; static bool allow_core_files = false; static time_t start_time;