From dd13dd39dbd3eec00ec1bff857b14bbc77fff86f Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Mon, 17 Aug 2026 22:40:26 +0200 Subject: [PATCH] Reorder function prototypes to match definition order While purely aesthetic, it makes reading the code easier to rearrange before the feature has shipped since doing it after risk backpatching conflicts. Also add missing prototypes. Backpatch to v19 where online checksums were introduced. Author: Fujii Masao Discussion: https://postgr.es/m/CAHGQGwEQ1-+iPQnUpTXYiHmzSz9ufFVkOK4kL_uyTdYt7jgg0Q@mail.gmail.com Backpatch-through: 19 --- src/backend/postmaster/datachecksum_state.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/backend/postmaster/datachecksum_state.c b/src/backend/postmaster/datachecksum_state.c index 78faf8de2f0..f69258bc33d 100644 --- a/src/backend/postmaster/datachecksum_state.c +++ b/src/backend/postmaster/datachecksum_state.c @@ -383,22 +383,24 @@ static DataChecksumsWorkerOperation operation; static void StartDataChecksumsWorkerLauncher(DataChecksumsWorkerOperation op, int cost_delay, int cost_limit); -static void DataChecksumsShmemRequest(void *arg); -static bool DatabaseExists(Oid dboid); static void ErrorOnInvalidDatabases(void); -static List *BuildDatabaseList(void); -static List *BuildRelationList(bool temp_relations, bool include_shared); -static void FreeDatabaseList(List *dblist); -static DataChecksumsWorkerResult ProcessDatabase(DataChecksumsWorkerDatabase *db); -static bool ProcessAllDatabases(void); static bool ProcessSingleRelationFork(Relation reln, ForkNumber forkNum, BufferAccessStrategy strategy); static void ResetDataChecksumsProgressCounters(void); +static bool ProcessSingleRelationByOid(Oid relationId, BufferAccessStrategy strategy); static BgwHandleStatus WaitForDataChecksumsWorkerState(BackgroundWorkerHandle *handle, bool wait_for_startup, pid_t *pidp, uint32 wait_event); +static DataChecksumsWorkerResult ProcessDatabase(DataChecksumsWorkerDatabase *db); +static void launcher_exit(int code, Datum arg); static void launcher_cancel_handler(SIGNAL_ARGS); static void WaitForAllTransactionsToFinish(void); +static bool ProcessAllDatabases(void); +static void DataChecksumsShmemRequest(void *arg); +static bool DatabaseExists(Oid dboid); +static List *BuildDatabaseList(void); +static void FreeDatabaseList(List *dblist); +static List *BuildRelationList(bool temp_relations, bool include_shared); const ShmemCallbacks DataChecksumsShmemCallbacks = { .request_fn = DataChecksumsShmemRequest,