database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-05 09:19:17 +03:00
Code

postgres_fdw: Avoid sharing list substructure.

Browse Source 
list_concat(list_concat(a, b), c) destructively changes both a and b;
to avoid such perils, copy lists of remote_conds before incorporating
them into larger lists via list_concat().

Ashutosh Bapat, per a report from Etsuro Fujita
This commit is contained in:
Robert Haas 2016-02-21 14:17:50 +05:30
parent 902fd1f4e2
commit dd077ef832
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
contrib/postgres_fdw/postgres_fdw.c
View File

@ -3488,30 +3488,30 @@ foreign_join_ok(PlannerInfo *root, RelOptInfo *joinrel, JoinType jointype,
{ {
case JOIN_INNER: case JOIN_INNER:
fpinfo->remote_conds = list_concat(fpinfo->remote_conds, fpinfo->remote_conds = list_concat(fpinfo->remote_conds,
fpinfo_i->remote_conds); list_copy(fpinfo_i->remote_conds));
fpinfo->remote_conds = list_concat(fpinfo->remote_conds, fpinfo->remote_conds = list_concat(fpinfo->remote_conds,
fpinfo_o->remote_conds); list_copy(fpinfo_o->remote_conds));
break; break;
case JOIN_LEFT: case JOIN_LEFT:
fpinfo->joinclauses = list_concat(fpinfo->joinclauses, fpinfo->joinclauses = list_concat(fpinfo->joinclauses,
fpinfo_i->remote_conds); list_copy(fpinfo_i->remote_conds));
fpinfo->remote_conds = list_concat(fpinfo->remote_conds, fpinfo->remote_conds = list_concat(fpinfo->remote_conds,
fpinfo_o->remote_conds); list_copy(fpinfo_o->remote_conds));
break; break;
case JOIN_RIGHT: case JOIN_RIGHT:
fpinfo->joinclauses = list_concat(fpinfo->joinclauses, fpinfo->joinclauses = list_concat(fpinfo->joinclauses,
fpinfo_o->remote_conds); list_copy(fpinfo_o->remote_conds));
fpinfo->remote_conds = list_concat(fpinfo->remote_conds, fpinfo->remote_conds = list_concat(fpinfo->remote_conds,
fpinfo_i->remote_conds); list_copy(fpinfo_i->remote_conds));
break; break;
case JOIN_FULL: case JOIN_FULL:
fpinfo->joinclauses = list_concat(fpinfo->joinclauses, fpinfo->joinclauses = list_concat(fpinfo->joinclauses,
fpinfo_i->remote_conds); list_copy(fpinfo_i->remote_conds));
fpinfo->joinclauses = list_concat(fpinfo->joinclauses, fpinfo->joinclauses = list_concat(fpinfo->joinclauses,
fpinfo_o->remote_conds); list_copy(fpinfo_o->remote_conds));
break; break;
default: default: